Change type of touch selection handles to POPUP

ui/views/touchui/touch_editing_menu.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/touchui/touch_editing_menu.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_strings.h"
+#include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/font_list.h"
 #include "ui/gfx/insets.h"
 #include "ui/gfx/text_utils.h"
 #include "ui/views/bubble/bubble_border.h"
 #include "ui/views/bubble/bubble_frame_view.h"
 #include "ui/views/controls/button/custom_button.h"
 #include "ui/views/controls/button/label_button.h"
@@ skipping 28 matching lines @@
   set_shadow(views::BubbleBorder::SMALL_SHADOW);
   set_parent_window(context);
   set_margins(gfx::Insets(kMenuMargin, kMenuMargin, kMenuMargin, kMenuMargin));
   set_use_focusless(true);
   set_adjust_if_offscreen(true);
 
   SetLayoutManager(new BoxLayout(BoxLayout::kHorizontal, 0, 0,
       kSpacingBetweenButtons));
   CreateButtons();
   views::BubbleDelegateView::CreateBubble(this);
+  // A transient child is not stacked above its parent upon creation; so, we
+  // do it manually here.
+  // TODO(mohsen): Remove after the above bug is fixed in the transient window
+  // management: crbug.com/352371.
+  GetWidget()->GetNativeView()->parent()->StackChildAbove(
+      GetWidget()->GetNativeView(), context);

[sadrul, 2014/03/14 18:30:07]

What does the fix for this look like? Can we land this fix first?

[mohsen, 2014/03/14 19:15:25]

 2014/03/14 18:30:07, sadrul wrote:
There is a TransientWindowManager::OnChildStackingChanged(child) method that
restacks transient children of child properly. The simplest fix would be to use
this method after a window has become transient child of another one
(TransientWindowManager::AddTransientChild()) or when a window that is the
transient child of another one is added to the windows hierarchy (when a
transient child is created, this one needs OnChildStackingChanged() to be public
to be accessible from Window::AddChild() or a similar method). This seems a bit
ugly and also inefficient and maybe a better solution is needed.

   GetWidget()->Show();
 }
 
 TouchEditingMenuView::~TouchEditingMenuView() {
 }
 
 // static
 TouchEditingMenuView* TouchEditingMenuView::Create(
     TouchEditingMenuController* controller,
     gfx::Rect anchor_rect,
@@ skipping 74 matching lines @@
   int h_border = (kMenuButtonWidth - gfx::GetStringWidth(label, font_list)) / 2;
   button_border->set_insets(
       gfx::Insets(v_border, h_border, v_border, h_border));
   button->SetBorder(button_border.PassAs<Border>());
   button->SetFontList(font_list);
   button->set_tag(tag);
   return button;
 }
 
 }  // namespace views