Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 1771613002: Revert of add setter on SkPaint that takes sk_sp (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of add setter on SkPaint that takes sk_sp (patchset #1 id:1 of https://codereview.chromium.org/1769803002/ ) Reason for revert: investigate leak Original issue's description: > add setter on SkPaint that takes sk_sp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769803002 > > TBR= > > Committed: https://skia.googlesource.com/skia/+/a917eba6ea8a6936f2c9271e487b14d14b99c98e TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/992854d62e179a589aa7366e443246e3672c3248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -95 lines) Patch
M include/core/SkPaint.h View 12 chunks +19 lines, -28 lines 0 comments Download
M src/core/SkPaint.cpp View 13 chunks +110 lines, -67 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of add setter on SkPaint that takes sk_sp
4 years, 9 months ago (2016-03-06 01:51:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771613002/1
4 years, 9 months ago (2016-03-06 01:51:39 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-06 01:51:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/992854d62e179a589aa7366e443246e3672c3248

Powered by Google App Engine
This is Rietveld 408576698