Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: include/core/SkPaint.h

Issue 1771613002: Revert of add setter on SkPaint that takes sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPaint.h
diff --git a/include/core/SkPaint.h b/include/core/SkPaint.h
index 39ee1e0de1d9b98a1b7b7c005ebd8bb44dc5522d..7090f3e2499f3f68255ae1fc3e641e9e37f1dd81 100644
--- a/include/core/SkPaint.h
+++ b/include/core/SkPaint.h
@@ -476,7 +476,7 @@
The shader's reference count is not affected.
@return the paint's shader (or NULL)
*/
- SkShader* getShader() const { return fShader.get(); }
+ SkShader* getShader() const { return fShader; }
/** Set or clear the shader object.
* Shaders specify the source color(s) for what is being drawn. If a paint
@@ -500,13 +500,12 @@
* @return shader
*/
SkShader* setShader(SkShader* shader);
- void setShader(sk_sp<SkShader>);
/** Get the paint's colorfilter. If there is a colorfilter, its reference
count is not changed.
@return the paint's colorfilter (or NULL)
*/
- SkColorFilter* getColorFilter() const { return fColorFilter.get(); }
+ SkColorFilter* getColorFilter() const { return fColorFilter; }
/** Set or clear the paint's colorfilter, returning the parameter.
<p />
@@ -516,14 +515,13 @@
@return filter
*/
SkColorFilter* setColorFilter(SkColorFilter* filter);
- void setColorFilter(sk_sp<SkColorFilter>);
/** Get the paint's xfermode object.
<p />
The xfermode's reference count is not affected.
@return the paint's xfermode (or NULL)
*/
- SkXfermode* getXfermode() const { return fXfermode.get(); }
+ SkXfermode* getXfermode() const { return fXfermode; }
/** Set or clear the xfermode object.
<p />
@@ -536,7 +534,6 @@
@return xfermode
*/
SkXfermode* setXfermode(SkXfermode* xfermode);
- void setXfermode(sk_sp<SkXfermode>);
/** Create an xfermode based on the specified Mode, and assign it into the
paint, returning the mode that was set. If the Mode is SrcOver, then
@@ -549,7 +546,7 @@
The patheffect reference count is not affected.
@return the paint's patheffect (or NULL)
*/
- SkPathEffect* getPathEffect() const { return fPathEffect.get(); }
+ SkPathEffect* getPathEffect() const { return fPathEffect; }
/** Set or clear the patheffect object.
<p />
@@ -562,14 +559,13 @@
@return effect
*/
SkPathEffect* setPathEffect(SkPathEffect* effect);
- void setPathEffect(sk_sp<SkPathEffect>);
/** Get the paint's maskfilter object.
<p />
The maskfilter reference count is not affected.
@return the paint's maskfilter (or NULL)
*/
- SkMaskFilter* getMaskFilter() const { return fMaskFilter.get(); }
+ SkMaskFilter* getMaskFilter() const { return fMaskFilter; }
/** Set or clear the maskfilter object.
<p />
@@ -582,7 +578,6 @@
@return maskfilter
*/
SkMaskFilter* setMaskFilter(SkMaskFilter* maskfilter);
- void setMaskFilter(sk_sp<SkMaskFilter>);
// These attributes are for text/fonts
@@ -592,7 +587,7 @@
measuring text. The typeface reference count is not affected.
@return the paint's typeface (or NULL)
*/
- SkTypeface* getTypeface() const { return fTypeface.get(); }
+ SkTypeface* getTypeface() const { return fTypeface; }
/** Set or clear the typeface object.
<p />
@@ -605,14 +600,13 @@
@return typeface
*/
SkTypeface* setTypeface(SkTypeface* typeface);
- void setTypeface(sk_sp<SkTypeface>);
/** Get the paint's rasterizer (or NULL).
<p />
The raster controls how paths/text are turned into alpha masks.
@return the paint's rasterizer (or NULL)
*/
- SkRasterizer* getRasterizer() const { return fRasterizer.get(); }
+ SkRasterizer* getRasterizer() const { return fRasterizer; }
/** Set or clear the rasterizer object.
<p />
@@ -626,17 +620,15 @@
@return rasterizer
*/
SkRasterizer* setRasterizer(SkRasterizer* rasterizer);
- void setRasterizer(sk_sp<SkRasterizer>);
-
- SkImageFilter* getImageFilter() const { return fImageFilter.get(); }
+
+ SkImageFilter* getImageFilter() const { return fImageFilter; }
SkImageFilter* setImageFilter(SkImageFilter*);
- void setImageFilter(sk_sp<SkImageFilter>);
/**
* Return the paint's SkDrawLooper (if any). Does not affect the looper's
* reference count.
*/
- SkDrawLooper* getLooper() const { return fLooper.get(); }
+ SkDrawLooper* getLooper() const { return fLooper; }
/**
* Set or clear the looper object.
@@ -650,7 +642,6 @@
* @return looper
*/
SkDrawLooper* setLooper(SkDrawLooper* looper);
- void setLooper(sk_sp<SkDrawLooper>);
enum Align {
kLeft_Align,
@@ -1035,15 +1026,15 @@
SK_TO_STRING_NONVIRT()
private:
- sk_sp<SkTypeface> fTypeface;
- sk_sp<SkPathEffect> fPathEffect;
- sk_sp<SkShader> fShader;
- sk_sp<SkXfermode> fXfermode;
- sk_sp<SkMaskFilter> fMaskFilter;
- sk_sp<SkColorFilter> fColorFilter;
- sk_sp<SkRasterizer> fRasterizer;
- sk_sp<SkDrawLooper> fLooper;
- sk_sp<SkImageFilter> fImageFilter;
+ SkTypeface* fTypeface;
+ SkPathEffect* fPathEffect;
+ SkShader* fShader;
+ SkXfermode* fXfermode;
+ SkMaskFilter* fMaskFilter;
+ SkColorFilter* fColorFilter;
+ SkRasterizer* fRasterizer;
+ SkDrawLooper* fLooper;
+ SkImageFilter* fImageFilter;
SkScalar fTextSize;
SkScalar fTextScaleX;
« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698