IDL compiler: SVGNames

IDL compiler: SVGNames

Remaining: 14 => 12

Patch a bit long b/c need to pass |interface| down to scoped_name()
(for both getter and setter), but content otherwise simple.

BUG=239771
R=haraken, kouhei
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167669

[kouhei (in TOK), 2014-02-24 07:24:25]

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_attributes.py:340: namespace = 'SVGNames' if
interface.name.startswith('SVG') else 'HTMLNames'
What happens for XMLNames and XLinkNames?

[Nils Barth (inactive), 2014-02-24 07:27:52]

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_attributes.py:340: namespace = 'SVGNames' if
interface.name.startswith('SVG') else 'HTMLNames'
On 2014/02/24 07:24:25, kouhei wrote:
> What happens for XMLNames and XLinkNames?

They don't occur in bindings:
only HTMLNames and (2 cases of) SVGNames

[kouhei (in TOK), 2014-02-24 07:34:33]

On 2014/02/24 07:27:52, Nils Barth wrote:
>
https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
> File Source/bindings/scripts/unstable/v8_attributes.py (right):
> 
>
https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
> Source/bindings/scripts/unstable/v8_attributes.py:340: namespace = 'SVGNames'
if
> interface.name.startswith('SVG') else 'HTMLNames'
> On 2014/02/24 07:24:25, kouhei wrote:
> > What happens for XMLNames and XLinkNames?
> 
> They don't occur in bindings:
> only HTMLNames and (2 cases of) SVGNames

I see. These seems to be only used when specified [Reflect].

[kouhei (in TOK), 2014-02-24 07:34:43]

lgtm

[Nils Barth (inactive), 2014-02-24 07:35:15]

On 2014/02/24 07:34:33, kouhei wrote:
> I see. These seems to be only used when specified [Reflect].

Exactly; thanks!

[haraken, 2014-02-24 07:36:26]

LGTM

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_attributes.py:340: namespace = 'SVGNames' if
interface.name.startswith('SVG') else 'HTMLNames'
On 2014/02/24 07:27:52, Nils Barth wrote:
> On 2014/02/24 07:24:25, kouhei wrote:
> > What happens for XMLNames and XLinkNames?
> 
> They don't occur in bindings:
> only HTMLNames and (2 cases of) SVGNames

I guess we have a plan to remove the namespace distinction of SVG, HTML etc. (I
don't know if anyone is working on it.)

[Nils Barth (inactive), 2014-02-24 07:37:39]

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
File Source/bindings/scripts/unstable/v8_attributes.py (right):

https://codereview.chromium.org/177143002/diff/1/Source/bindings/scripts/unst...
Source/bindings/scripts/unstable/v8_attributes.py:340: namespace = 'SVGNames' if
interface.name.startswith('SVG') else 'HTMLNames'
On 2014/02/24 07:36:26, haraken wrote:
> I guess we have a plan to remove the namespace distinction of SVG, HTML etc.
(I
> don't know if anyone is working on it.)

I'll see if we can fix this during cleanup, or at least link to a tracking bug.

[Nils Barth (inactive), 2014-02-24 07:37:46]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-02-24 07:37:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/177143002/1

[commit-bot: I haz the power, 2014-02-24 07:38:04]

Change committed as 167669