IDL compiler: SVGNames

Source/bindings/scripts/unstable/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 174 matching lines @@
 
     contents.update({
         'cpp_value': cpp_value,
         'v8_set_return_value_for_main_world': v8_set_return_value_statement(for_main_world=True),
         'v8_set_return_value': v8_set_return_value_statement(),
     })
 
 
 def getter_expression(interface, attribute, contents):
     arguments = []
-    this_getter_base_name = getter_base_name(attribute, arguments)
+    this_getter_base_name = getter_base_name(interface, attribute, arguments)
     getter_name = v8_utilities.scoped_name(interface, attribute, this_getter_base_name)
 
     arguments.extend(v8_utilities.call_with_arguments(attribute))
     if ('ImplementedBy' in attribute.extended_attributes and
         not attribute.is_static):
         arguments.append('*imp')
     if attribute.is_nullable:
         arguments.append('isNull')
     if contents['is_getter_raises_exception']:
         arguments.append('exceptionState')
     return '%s(%s)' % (getter_name, ', '.join(arguments))
 
 
 CONTENT_ATTRIBUTE_GETTER_NAMES = {
     'boolean': 'fastHasAttribute',
     'long': 'getIntegralAttribute',
     'unsigned long': 'getUnsignedIntegralAttribute',
 }
 
 
-def getter_base_name(attribute, arguments):
+def getter_base_name(interface, attribute, arguments):
     extended_attributes = attribute.extended_attributes
     if 'Reflect' not in extended_attributes:
         return uncapitalize(cpp_name(attribute))
 
     content_attribute_name = extended_attributes['Reflect'] or attribute.name.lower()
     if content_attribute_name in ['class', 'id', 'name']:
         # Special-case for performance optimization.
         return 'get%sAttribute' % content_attribute_name.capitalize()
 
-    arguments.append(scoped_content_attribute_name(attribute))
+    arguments.append(scoped_content_attribute_name(interface, attribute))
 
     idl_type = attribute.idl_type
     if idl_type in CONTENT_ATTRIBUTE_GETTER_NAMES:
         return CONTENT_ATTRIBUTE_GETTER_NAMES[idl_type]
     if 'URL' in attribute.extended_attributes:
         return 'getURLAttribute'
     return 'fastGetAttribute'
 
 
 def is_keep_alive_for_gc(interface, attribute):
@@ skipping 45 matching lines @@
         'cpp_setter': setter_expression(interface, attribute, contents),
         'v8_value_to_local_cpp_value': v8_types.v8_value_to_local_cpp_value(
             attribute.idl_type, extended_attributes, 'jsValue', 'cppValue'),
     })
 
 
 def setter_expression(interface, attribute, contents):
     extended_attributes = attribute.extended_attributes
     arguments = v8_utilities.call_with_arguments(attribute, extended_attributes.get('SetterCallWith'))
 
-    this_setter_base_name = setter_base_name(attribute, arguments)
+    this_setter_base_name = setter_base_name(interface, attribute, arguments)
     setter_name = v8_utilities.scoped_name(interface, attribute, this_setter_base_name)
 
     if ('ImplementedBy' in extended_attributes and
         not attribute.is_static):
         arguments.append('*imp')
     idl_type = attribute.idl_type
     if idl_type == 'EventHandler':
         getter_name = v8_utilities.scoped_name(interface, attribute, cpp_name(attribute))
         contents['event_handler_getter_expression'] = '%s(%s)' % (
             getter_name, ', '.join(arguments))
@@ skipping 14 matching lines @@
     return '%s(%s)' % (setter_name, ', '.join(arguments))
 
 
 CONTENT_ATTRIBUTE_SETTER_NAMES = {
     'boolean': 'setBooleanAttribute',
     'long': 'setIntegralAttribute',
     'unsigned long': 'setUnsignedIntegralAttribute',
 }
 
 
-def setter_base_name(attribute, arguments):
+def setter_base_name(interface, attribute, arguments):
     if 'Reflect' not in attribute.extended_attributes:
         return 'set%s' % capitalize(cpp_name(attribute))
-    arguments.append(scoped_content_attribute_name(attribute))
+    arguments.append(scoped_content_attribute_name(interface, attribute))
 
     idl_type = attribute.idl_type
     if idl_type in CONTENT_ATTRIBUTE_SETTER_NAMES:
         return CONTENT_ATTRIBUTE_SETTER_NAMES[idl_type]
     return 'setAttribute'
 
 
-def scoped_content_attribute_name(attribute):
+def scoped_content_attribute_name(interface, attribute):
     content_attribute_name = attribute.extended_attributes['Reflect'] or attribute.name.lower()
-    namespace = 'HTMLNames'  # FIXME: can be SVG too
+    namespace = 'SVGNames' if interface.name.startswith('SVG') else 'HTMLNames'

[kouhei (in TOK), 2014/02/24 07:24:25]

What happens for XMLNames and XLinkNames?

[Nils Barth (inactive), 2014/02/24 07:27:52]

They don't occur in bindings:
only HTMLNames and (2 cases of) SVGNames

[haraken, 2014/02/24 07:36:26]

I guess we have a plan to remove the namespace distinction of SVG, HTML etc. (I
don't know if anyone is working on it.)

[Nils Barth (inactive), 2014/02/24 07:37:40]

I'll see if we can fix this during cleanup, or at least link to a tracking bug.

     includes.add('%s.h' % namespace)
     return '%s::%sAttr' % (namespace, content_attribute_name)
 
 
 ################################################################################
 # Attribute configuration
 ################################################################################
 
 # [Replaceable]
 def setter_callback_name(interface, attribute):
@@ skipping 38 matching lines @@
         property_attributes_list.append('v8::DontDelete')
     return property_attributes_list or ['v8::None']
 
 
 ################################################################################
 # Constructors
 ################################################################################
 
 def is_constructor_attribute(attribute):
     return attribute.idl_type.endswith('Constructor')