Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1771313002: Math.random must not be executed when creating a snapshot. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Math.random must not be executed when creating a snapshot. Previously, the assertion does not include code executed in the custom heap snapshot. TBR=hablich@chromium.org BUG=v8:4810 LOG=N Committed: https://crrev.com/232cd81aba334639be0ac1047ee03345ece805d3 Cr-Commit-Position: refs/heads/master@{#34583}

Patch Set 1 #

Patch Set 2 : make it a CHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime/runtime-maths.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Yang
4 years, 9 months ago (2016-03-08 12:13:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1771313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1771313002/20001
4 years, 9 months ago (2016-03-08 12:18:41 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 12:45:35 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/232cd81aba334639be0ac1047ee03345ece805d3 Cr-Commit-Position: refs/heads/master@{#34583}
4 years, 9 months ago (2016-03-08 12:45:55 UTC) #8
Michael Hablich
4 years, 9 months ago (2016-03-08 19:42:58 UTC) #9
Message was sent while issue was closed.
On 2016/03/08 12:45:55, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/232cd81aba334639be0ac1047ee03345ece805d3
> Cr-Commit-Position: refs/heads/master@{#34583}

lgtm

Powered by Google App Engine
This is Rietveld 408576698