src/runtime/runtime-maths.cc - Issue 1771313002: Math.random must not be executed when creating a snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-maths.cc

Issue 1771313002: Math.random must not be executed when creating a snapshot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: make it a CHECK Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-maths.cc

diff --git a/src/runtime/runtime-maths.cc b/src/runtime/runtime-maths.cc

index f3049f9fabae348fff4a7d9194a439b76e1fde76..59bf372b00a8bab3becb3c05c6111285c98617cf 100644

--- a/src/runtime/runtime-maths.cc

+++ b/src/runtime/runtime-maths.cc

@@ -229,7 +229,7 @@ RUNTIME_FUNCTION(Runtime_GenerateRandomNumbers) {

HandleScope scope(isolate);

DCHECK(args.length() == 1);

// Random numbers in the snapshot are not really that random.

- DCHECK(!isolate->bootstrapper()->IsActive());

+ CHECK(!isolate->serializer_enabled());

static const int kState0Offset = 0;

static const int kState1Offset = 1;

static const int kRandomBatchSize = 64;

« no previous file with comments | « no previous file | no next file » | no next file with comments »