Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1771243002: Change when enum constant elements are created to fix bug in re-creating ASTs from existing element… (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change when enum constant elements are created to fix bug in re-creating ASTs from existing element models R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d8786ac278f98e771e230970ee860f35ea7a6ff1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +33 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +2 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-08 04:21:09 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-08 06:45:17 UTC) #3
Paul Berry
lgtm
4 years, 9 months ago (2016-03-08 16:37:24 UTC) #4
Brian Wilkerson
4 years, 9 months ago (2016-03-08 16:45:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8786ac278f98e771e230970ee860f35ea7a6ff1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698