Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1771243002: Change when enum constant elements are created to fix bug in re-creating ASTs from existing element… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index 479a787c3d1c2bed22d656edaa82bbca9102b379..a15846bab9d38c6cf4258f0b256c4a37f60cd560 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -3408,13 +3408,7 @@ class EnumMemberBuilder extends RecursiveAstVisitor<Object> {
int constantCount = constants.length;
for (int i = 0; i < constantCount; i++) {
EnumConstantDeclaration constant = constants[i];
- SimpleIdentifier constantName = constant.name;
- FieldElementImpl constantField =
- new ConstFieldElementImpl.forNode(constantName);
- constantField.static = true;
- constantField.const3 = true;
- constantField.type = enumType;
- setElementDocumentationComment(constantField, constant);
+ FieldElementImpl constantField = constant.name.staticElement;
//
// Create a value for the constant.
//
@@ -3426,8 +3420,7 @@ class EnumMemberBuilder extends RecursiveAstVisitor<Object> {
constantValues.add(value);
constantField.evaluationResult = new EvaluationResultImpl(value);
fields.add(constantField);
- getters.add(_createGetter(constantField));
- constantName.staticElement = constantField;
+ getters.add(constantField.getter);
}
//
// Build the value of the 'values' field.
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/builder.dart ('k') | pkg/analyzer/test/generated/declaration_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698