Issue 177123013: Garden-o-matic: Display bugs from the commit BUG=... line in commit summary

Issue 177123013: Garden-o-matic: Display bugs from the commit BUG=... line in commit summary (Closed)

Created:
6 years, 9 months ago by apavlov

Modified:
6 years, 9 months ago

Reviewers:
dglazkov, eseidel

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Garden-o-matic: Display bugs from the commit BUG=... line in commit summary This patch also allows multiple bugs on the BUG= line, perhaps having some non-digit characters (see r168027 for an example). It also occurred to me that with this patch committed, we should require that BUG= (and R=) starts at the beginning of line NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168266

Patch Set 1 #

Total comments: 1

Patch Set 2 : Only look for R= and BUG= at line start #

Patch Set 3 : Comment addressed #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -25 lines)			Patch
M	Tools/GardeningServer/scripts/model_unittests.js	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	Tools/GardeningServer/scripts/svn-log.js	View	1	2 chunks	+13 lines, -7 lines	0 comments	Download
M	Tools/GardeningServer/scripts/svn-log_unittests.js	View	1	6 chunks	+50 lines, -5 lines	0 comments	Download
M	Tools/GardeningServer/scripts/ui.js	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Tools/GardeningServer/scripts/ui/notifications.js	View	1 2	2 chunks	+16 lines, -5 lines	0 comments	Download
M	Tools/GardeningServer/styles/notifications.css	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

apavlov

The screenshot is found at http://i.imgur.com/MiIWFNt.png

6 years, 9 months ago (2014-02-28 13:04:50 UTC) #1

apavlov

https://codereview.chromium.org/177123013/diff/1/Tools/GardeningServer/scripts/ui/notifications.js File Tools/GardeningServer/scripts/ui/notifications.js (right): https://codereview.chromium.org/177123013/diff/1/Tools/GardeningServer/scripts/ui/notifications.js#newcode122 Tools/GardeningServer/scripts/ui/notifications.js:122: return 'http://crbug.com/' + bugID; Any suggestions on this? Should ...

6 years, 9 months ago (2014-02-28 13:15:24 UTC) #2

dglazkov

On 2014/02/28 13:15:24, apavlov wrote: > https://codereview.chromium.org/177123013/diff/1/Tools/GardeningServer/scripts/ui/notifications.js > File Tools/GardeningServer/scripts/ui/notifications.js (right): > > https://codereview.chromium.org/177123013/diff/1/Tools/GardeningServer/scripts/ui/notifications.js#newcode122 > ...

6 years, 9 months ago (2014-02-28 23:19:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/177123013/40001

6 years, 9 months ago (2014-03-03 06:48:45 UTC) #6

Message was sent while issue was closed.

Change committed as 168266

Expand Messages | Collapse Messages