Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: Tools/GardeningServer/scripts/model_unittests.js

Issue 177123013: Garden-o-matic: Display bugs from the commit BUG=... line in commit summary (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comment addressed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/scripts/svn-log.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/model_unittests.js
diff --git a/Tools/GardeningServer/scripts/model_unittests.js b/Tools/GardeningServer/scripts/model_unittests.js
index 50e34498bd2762a5c1f04176ff7991941559b873..38522c99e055d5a112f5b81180d45748f833a650 100644
--- a/Tools/GardeningServer/scripts/model_unittests.js
+++ b/Tools/GardeningServer/scripts/model_unittests.js
@@ -141,7 +141,7 @@ asyncTest("updateRecentCommits", 2, function() {
"summary": "This matches Gecko's behavior for these types of properties.",
"author": "mkwst@chromium.org",
"reviewer": "jochen@chromium.org",
- "bugID": 13,
+ "bugID": [13],
"revertedRevision": undefined,
},
{
@@ -151,7 +151,7 @@ asyncTest("updateRecentCommits", 2, function() {
"summary": "core/platform may not depend on core/ even for testing.",
"author": "eseidel@chromium.org",
"reviewer": "abarth@chromium.org, abarth",
- "bugID": 12,
+ "bugID": [12],
"revertedRevision": undefined
},
{
@@ -161,7 +161,7 @@ asyncTest("updateRecentCommits", 2, function() {
"summary": "These were all failures noticed when running check-blink-deps",
"author": "eseidel@chromium.org",
"reviewer": "abarth@chromium.org, abarth",
- "bugID": 11,
+ "bugID": [11],
"revertedRevision": undefined
}
]);
@@ -186,10 +186,10 @@ asyncTest("commitDataListForRevisionRange", 6, function() {
return commitData.bugID;
}
- deepEqual(model.commitDataListForRevisionRange(3, 3).map(extractBugIDs), [13]);
- deepEqual(model.commitDataListForRevisionRange(1, 3).map(extractBugIDs), [11, 12, 13]);
- deepEqual(model.commitDataListForRevisionRange(0, 1).map(extractBugIDs), [11]);
- deepEqual(model.commitDataListForRevisionRange(0, 4).map(extractBugIDs), [11, 12, 13]);
+ deepEqual(model.commitDataListForRevisionRange(3, 3).map(extractBugIDs), [[13]]);
+ deepEqual(model.commitDataListForRevisionRange(1, 3).map(extractBugIDs), [[11], [12], [13]]);
+ deepEqual(model.commitDataListForRevisionRange(0, 1).map(extractBugIDs), [[11]]);
+ deepEqual(model.commitDataListForRevisionRange(0, 4).map(extractBugIDs), [[11], [12], [13]]);
deepEqual(model.commitDataListForRevisionRange(4, 0).map(extractBugIDs), []);
delete model.state.recentCommits;
});
« no previous file with comments | « no previous file | Tools/GardeningServer/scripts/svn-log.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698