Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1771223002: Migrate *-ime-thread switches to feature API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: plumb imeadapter instead and fixed nits Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1781 matching lines...) Expand 10 before | Expand all | Expand 10 after
1792 SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)} 1792 SINGLE_VALUE_TYPE(extensions::switches::kEnableTabForDesktopShare)}
1793 #endif 1793 #endif
1794 #if defined(OS_ANDROID) 1794 #if defined(OS_ANDROID)
1795 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME, 1795 {"enable-ntp-snippets", IDS_FLAGS_ENABLE_NTP_SNIPPETS_NAME,
1796 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid, 1796 IDS_FLAGS_ENABLE_NTP_SNIPPETS_DESCRIPTION, kOsAndroid,
1797 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)}, 1797 FEATURE_VALUE_TYPE(chrome::android::kNTPSnippetsFeature)},
1798 #endif // defined(OS_ANDROID) 1798 #endif // defined(OS_ANDROID)
1799 #if defined(OS_ANDROID) 1799 #if defined(OS_ANDROID)
1800 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME, 1800 {"ime-thread", IDS_FLAGS_IME_THREAD_NAME,
1801 IDS_FLAGS_IME_THREAD_DESCRIPTION, kOsAndroid, 1801 IDS_FLAGS_IME_THREAD_DESCRIPTION, kOsAndroid,
1802 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableImeThread, 1802 FEATURE_VALUE_TYPE(features::kImeThread)},
1803 switches::kDisableImeThread)},
1804 #endif // defined(OS_ANDROID) 1803 #endif // defined(OS_ANDROID)
1805 // NOTE: Adding new command-line switches requires adding corresponding 1804 // NOTE: Adding new command-line switches requires adding corresponding
1806 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1805 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1807 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1806 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1808 }; 1807 };
1809 1808
1810 class FlagsStateSingleton { 1809 class FlagsStateSingleton {
1811 public: 1810 public:
1812 FlagsStateSingleton() 1811 FlagsStateSingleton()
1813 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 1812 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
2004 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2003 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2005 2004
2006 const FeatureEntry* GetFeatureEntries(size_t* count) { 2005 const FeatureEntry* GetFeatureEntries(size_t* count) {
2007 *count = arraysize(kFeatureEntries); 2006 *count = arraysize(kFeatureEntries);
2008 return kFeatureEntries; 2007 return kFeatureEntries;
2009 } 2008 }
2010 2009
2011 } // namespace testing 2010 } // namespace testing
2012 2011
2013 } // namespace about_flags 2012 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/ime_adapter_android.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698