Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6493)

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 1770943005: Removed AttemptResult enum in favor of using DefaultWebClientState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dont_record_async_duration
Patch Set: Merge + simplified Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc
diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
index aa09a9f665dd072cb7db0150a66423621a8cc3b8..eb328443b957652c8a0fd218459c94f510071778 100644
--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
@@ -23,20 +23,14 @@ class FakeExternalProtocolHandlerWorker
private:
~FakeExternalProtocolHandlerWorker() override {}
- void CheckIsDefault() override {
+ void CheckIsDefault(bool is_following_set_as_default) override {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&FakeExternalProtocolHandlerWorker::OnCheckIsDefaultComplete,
- this, os_state_));
+ this, os_state_, is_following_set_as_default));
}
- void SetAsDefault() override {
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(
- &FakeExternalProtocolHandlerWorker::OnSetAsDefaultAttemptComplete,
- this, AttemptResult::SUCCESS));
- }
+ void SetAsDefault() override { CheckIsDefault(true); }
shell_integration::DefaultWebClientState os_state_;
};

Powered by Google App Engine
This is Rietveld 408576698