Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5732)

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 1770943005: Removed AttemptResult enum in favor of using DefaultWebClientState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dont_record_async_duration
Patch Set: Merge + simplified Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
index 145b6e3a52935f64e8305ce52e1fb197a29bb972..a32305edfcef21746d7e8d965440d5fe1c71a950 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
@@ -149,7 +149,7 @@ class FakeProtocolClientWorker
private:
~FakeProtocolClientWorker() override {}
- void CheckIsDefault() override {
+ void CheckIsDefault(bool is_following_set_as_default) override {
shell_integration::DefaultWebClientState state =
shell_integration::IS_DEFAULT;
if (force_failure_)
@@ -158,15 +158,10 @@ class FakeProtocolClientWorker
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&FakeProtocolClientWorker::OnCheckIsDefaultComplete, this,
- state));
+ state, is_following_set_as_default));
}
- void SetAsDefault() override {
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&FakeProtocolClientWorker::OnSetAsDefaultAttemptComplete,
- this, AttemptResult::SUCCESS));
- }
+ void SetAsDefault() override { CheckIsDefault(true); }
private:
bool force_failure_;

Powered by Google App Engine
This is Rietveld 408576698