Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1770733002: Back out ignore quick-fix. (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Back out ignore quick-fix. As per, https://github.com/dart-lang/sdk/issues/25926, we'll migrate this behavior to the IDE side. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f506639391025d859575fab861045701e1c7bcac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +0 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 3 chunks +1 line, -5 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 9 months ago (2016-03-06 22:04:11 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-06 23:42:21 UTC) #3
pquitslund
4 years, 9 months ago (2016-03-07 17:25:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f506639391025d859575fab861045701e1c7bcac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698