Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: pkg/analysis_server/test/services/correction/fix_test.dart

Issue 1770733002: Back out ignore quick-fix. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/edit/fixes_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/fix_test.dart
diff --git a/pkg/analysis_server/test/services/correction/fix_test.dart b/pkg/analysis_server/test/services/correction/fix_test.dart
index c69487ea5bc2bff57f1cee3335b99a47e0ac1894..853a4488837dafc316da747af9ec0f5dcc30426f 100644
--- a/pkg/analysis_server/test/services/correction/fix_test.dart
+++ b/pkg/analysis_server/test/services/correction/fix_test.dart
@@ -252,22 +252,6 @@ class Test {
''');
}
- test_addIgnoreWarning() async {
- resolveTestUnit('''
-main() {
- int x = ''; //invalid_assignment
-}
-''');
- await assertHasFix(
- DartFixKind.IGNORE_ERROR,
- '''
-main() {
- //ignore: invalid_assignment
- int x = ''; //invalid_assignment
-}
-''');
- }
-
test_addMissingParameter_function_positional_hasNamed() async {
resolveTestUnit('''
test({int a}) {}
@@ -489,8 +473,6 @@ main() {
}
if (error.message == message2) {
List<Fix> fixes = await _computeFixes(error);
- // remove ignore fix
- fixes.removeWhere((Fix fix) => fix.kind == DartFixKind.IGNORE_ERROR);
// has exactly one fix
expect(fixes, hasLength(1));
Fix fix = fixes[0];
« no previous file with comments | « pkg/analysis_server/test/edit/fixes_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698