Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1770533002: Change userid from a uint32_t to a string guid (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, creis+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@33connector
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change userid from a uint32_t to a string guid TBR=sky@chromium.org BUG= patch from issue 1760963003 at patchset 20001 (http://crrev.com/1760963003#ps20001) CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/cccfe2ac0e74379a36ce020db5c08c3ccffdd362 Cr-Commit-Position: refs/heads/master@{#379476}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -287 lines) Patch
M ash/mus/sysui_application.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/mus/sysui_application.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_system_app.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/font_service/font_service_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/font_service_app.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_app.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/mus_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/mus_app.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/display.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M components/mus/ws/display.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -5 lines 0 comments Download
M components/mus/ws/display_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/test_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/user_id.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/user_id_tracker.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M components/mus/ws/user_id_tracker.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M components/mus/ws/user_id_tracker_observer.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/ws/window_manager_factory_registry.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M components/mus/ws/window_manager_factory_registry.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M components/mus/ws/window_manager_factory_service.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/window_manager_factory_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M components/profile_service/profile_app.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M components/profile_service/profile_app.cc View 1 2 4 chunks +8 lines, -9 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 2 5 chunks +10 lines, -11 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_app_connection_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_context.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M content/test/data/web_ui_mojo_shell_test.js View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M mash/init/init.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mash/init/init.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mash/init/public/interfaces/login.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/login/login.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/login/login.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mash/screenlock/screenlock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/shell/shell_application_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/shell/shell_application_delegate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M mash/wm/window_manager_application.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/background/background_shell.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/connect_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/identity.h View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/shell/identity.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/application_test_base.h View 1 2 3 4 4 chunks +10 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/connector.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/lib/connector_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/shell_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_test.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/shell_test.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/public/interfaces/connector.mojom View 1 2 3 chunks +21 lines, -18 lines 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/interfaces/shell_client.mojom View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/shell.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/shell.cc View 1 10 chunks +24 lines, -19 lines 0 comments Download
M mojo/shell/standalone/context.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/tests/connect/connect_test.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_package.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/tests/connect/connect_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/tests/lifecycle/lifecycle_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/loader_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/tests/shell/driver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/shell/target.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770533002/60001
4 years, 9 months ago (2016-03-05 05:35:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/192019)
4 years, 9 months ago (2016-03-05 05:51:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770533002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770533002/80001
4 years, 9 months ago (2016-03-05 06:51:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/192029)
4 years, 9 months ago (2016-03-05 07:06:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770533002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770533002/100001
4 years, 9 months ago (2016-03-05 07:18:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/125994)
4 years, 9 months ago (2016-03-05 07:42:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770533002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770533002/120001
4 years, 9 months ago (2016-03-05 15:07:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/192047)
4 years, 9 months ago (2016-03-05 15:21:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770533002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770533002/140001
4 years, 9 months ago (2016-03-05 15:33:21 UTC) #20
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-05 16:54:24 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 16:56:02 UTC) #24
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/cccfe2ac0e74379a36ce020db5c08c3ccffdd362
Cr-Commit-Position: refs/heads/master@{#379476}

Powered by Google App Engine
This is Rietveld 408576698