Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: mojo/shell/public/cpp/shell_test.h

Issue 1770533002: Change userid from a uint32_t to a string guid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@33connector
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/cpp/shell_connection.h ('k') | mojo/shell/public/interfaces/connector.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/shell_test.h
diff --git a/mojo/shell/public/cpp/shell_test.h b/mojo/shell/public/cpp/shell_test.h
index 78a1a25f66930373dd018cfabf4a2e16c64dbae7..a839397324725a88761340daf3a43ddd946ecf5d 100644
--- a/mojo/shell/public/cpp/shell_test.h
+++ b/mojo/shell/public/cpp/shell_test.h
@@ -36,8 +36,8 @@ class ShellTestClient : public mojo::ShellClient {
protected:
void Initialize(Connector* connector,
const std::string& name,
- uint32_t id,
- uint32_t user_id) override;
+ const std::string& user_id,
+ uint32_t id) override;
private:
ShellTest* test_;
@@ -63,8 +63,8 @@ class ShellTest : public testing::Test {
// Instance information received from the Shell during Initialize().
const std::string& test_name() const { return initialize_name_; }
+ const std::string& test_userid() const { return initialize_userid_; }
uint32_t test_instance_id() const { return initialize_instance_id_; }
- uint32_t test_userid() const { return initialize_userid_; }
// By default, creates a simple ShellClient that captures the metadata sent
// via Initialize(). Override to customize, but custom implementations must
@@ -75,8 +75,8 @@ class ShellTest : public testing::Test {
// Call to set Initialize() metadata when GetShellClient() is overridden.
void InitializeCalled(Connector* connector,
const std::string& name,
- uint32_t id,
- uint32_t userid);
+ const std::string& userid,
+ uint32_t id);
// testing::Test:
void SetUp() override;
@@ -96,9 +96,9 @@ class ShellTest : public testing::Test {
Connector* connector_ = nullptr;
std::string initialize_name_;
+ std::string initialize_userid_ = shell::mojom::kInheritUserID;
uint32_t initialize_instance_id_ =
shell::mojom::Connector::kInvalidApplicationID;
- uint32_t initialize_userid_ = shell::mojom::Connector::kUserInherit;
DISALLOW_COPY_AND_ASSIGN(ShellTest);
};
« no previous file with comments | « mojo/shell/public/cpp/shell_connection.h ('k') | mojo/shell/public/interfaces/connector.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698