Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1770383006: [debugger] Removed unused GetStepInPositions method (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Removed unused GetStepInPositions method This method was added as part of DevTools experiment. Experiment UI was removed in https://codereview.chromium.org/201293007 2 years ago. Experiment backend was removed in https://codereview.chromium.org/1785533002/. R=yangguo@chromium.org LOG=N Committed: https://crrev.com/63f35c26d6fadf8f6a6022f7a82f0701ad9c7a87 Cr-Commit-Position: refs/heads/master@{#34688}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed BreakLocation::FromCodeOffsetSameStatement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -344 lines) Patch
M src/debug/debug.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/debug/debug.cc View 1 2 chunks +0 lines, -54 lines 0 comments Download
M src/debug/mirrors.js View 2 chunks +0 lines, -28 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D test/mjsunit/debug-stepin-positions.js View 1 chunk +0 lines, -227 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kozy
ptal
4 years, 9 months ago (2016-03-09 23:20:31 UTC) #1
Yang
Thanks for tying up loose ends! https://codereview.chromium.org/1770383006/diff/1/src/debug/debug.cc File src/debug/debug.cc (left): https://codereview.chromium.org/1770383006/diff/1/src/debug/debug.cc#oldcode1689 src/debug/debug.cc:1689: BreakLocation::FromCodeOffsetSameStatement(debug_info, call_offset, This ...
4 years, 9 months ago (2016-03-10 01:48:24 UTC) #2
kozy
Removed one more function :) https://codereview.chromium.org/1770383006/diff/1/src/debug/debug.cc File src/debug/debug.cc (left): https://codereview.chromium.org/1770383006/diff/1/src/debug/debug.cc#oldcode1689 src/debug/debug.cc:1689: BreakLocation::FromCodeOffsetSameStatement(debug_info, call_offset, On 2016/03/10 ...
4 years, 9 months ago (2016-03-10 02:05:13 UTC) #4
Yang
On 2016/03/10 02:05:13, kozyatinskiy wrote: > Removed one more function :) > > https://codereview.chromium.org/1770383006/diff/1/src/debug/debug.cc > ...
4 years, 9 months ago (2016-03-10 06:10:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770383006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770383006/20001
4 years, 9 months ago (2016-03-10 09:06:22 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 09:33:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770383006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770383006/20001
4 years, 9 months ago (2016-03-10 18:08:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 18:11:47 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 18:12:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63f35c26d6fadf8f6a6022f7a82f0701ad9c7a87
Cr-Commit-Position: refs/heads/master@{#34688}

Powered by Google App Engine
This is Rietveld 408576698