Issue 17702004: Only remove CHROME_SANDBOX_ENV from env if it is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17702004: Only remove CHROME_SANDBOX_ENV from env if it is present. (Closed)

Created:
7 years, 6 months ago by jln (very slow on Chromium)

Modified:
7 years, 6 months ago

Reviewers:
csharp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Only remove CHROME_SANDBOX_ENV from env if it is present. This will fix an error occuring on Windows. (patch from csharp@chromium.org) TBR=csharp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208535

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	testing/test_env.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

jln (very slow on Chromium)

Committed patchset #1 manually as r208535 (presubmit successful).

7 years, 6 months ago (2013-06-25 19:34:40 UTC) #1

Message was sent while issue was closed.

lgtm