testing/test_env.py - Issue 17702004: Only remove CHROME_SANDBOX_ENV from env if it is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test_env.py

Issue 17702004: Only remove CHROME_SANDBOX_ENV from env if it is present. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/test_env.py

diff --git a/testing/test_env.py b/testing/test_env.py

index a65b34b52157045a817f054914c2b73609c2c381..ec98a11ce61e82670b1788a16a08f3b0c6f9e57e 100755

--- a/testing/test_env.py

+++ b/testing/test_env.py

@@ -48,7 +48,8 @@ def enable_sandbox_if_required(env, verbose=False):

print ' %s' % CHROME_SANDBOX_ENV

# The variable should be removed from the environment, making

# the variable empty silently disables the sandbox.

- env.pop(CHROME_SANDBOX_ENV)

+ if env.get(CHROME_SANDBOX_ENV):

+ env.pop(CHROME_SANDBOX_ENV)

def fix_python_path(cmd):

« no previous file with comments | « no previous file | no next file » | no next file with comments »