third_party/libxslt/README.chromium - Issue 1770093002: Avoid illegal definition of snprintf in VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxslt/README.chromium

Issue 1770093002: Avoid illegal definition of snprintf in VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libxslt/README.chromium

diff --git a/third_party/libxslt/README.chromium b/third_party/libxslt/README.chromium

index 138e4eed58242b15d1c8dd21a52e3b8ae56e62f2..702c8e3e1334b9fd0fde8756ebd11c3033392daf 100644

--- a/third_party/libxslt/README.chromium

+++ b/third_party/libxslt/README.chromium

@@ -34,6 +34,8 @@ On Windows:

In win32\ run

cscript //E:jscript configure.js compiler=msvc iconv=no xslt_debug=no mem_debug=no debugger=no modules=no

and copy config.h to Linux in win32/

+Patch win32/config.h to add "#if _MSC_VER < 1900 // Cannot define this in VS 2015 and above!"

scottmg 2016/03/07 20:32:36 This should be in the libxml readme, not the libxs

brucedawson 2016/03/07 21:17:07 D'oh! Done.

+and "#endif around the #define of snprintf.

Remove:

doc/

« no previous file with comments | « third_party/libxml/win32/config.h ('k') | no next file » | no next file with comments »