third_party/libxslt/README.chromium - Issue 1770093002: Avoid illegal definition of snprintf in VS 2015

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libxslt/README.chromium

Issue 1770093002: Avoid illegal definition of snprintf in VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: libxslt	1 Name: libxslt

2 URL: http://xmlsoft.org/XSLT	2 URL: http://xmlsoft.org/XSLT

3 Version: 1.1.28	3 Version: 1.1.28

4 Security Critical: yes	4 Security Critical: yes

5 License: MIT	5 License: MIT

6 License File: Copyright	6 License File: Copyright

7	7

8 Description:	8 Description:

9	9

10 libxslt from libxml.org.	10 libxslt from libxml.org.

(...skipping 16 matching lines...) Expand all Loading...
27 ../configure --without-debug --without-mem-debug --without-debugger --without-pl ugins --with-libxml-src=../../libxml/linux/	27 ../configure --without-debug --without-mem-debug --without-debugger --without-pl ugins --with-libxml-src=../../libxml/linux/

28 Patch to not define HAVE_CLOCK_GETTIME.	28 Patch to not define HAVE_CLOCK_GETTIME.

29	29

30 Do the same on Mac and copy the mac/config.h to Linux.	30 Do the same on Mac and copy the mac/config.h to Linux.

31	31

32 On Windows:	32 On Windows:

33	33

34 In win32\ run	34 In win32\ run

35 cscript //E:jscript configure.js compiler=msvc iconv=no xslt_debug=no mem_debug= no debugger=no modules=no	35 cscript //E:jscript configure.js compiler=msvc iconv=no xslt_debug=no mem_debug= no debugger=no modules=no

36 and copy config.h to Linux in win32/	36 and copy config.h to Linux in win32/

	37 Patch win32/config.h to add "#if _MSC_VER < 1900 // Cannot define this in VS 201 5 and above!"
	scottmg 2016/03/07 20:32:36 This should be in the libxml readme, not the libxs This should be in the libxml readme, not the libxslt one? brucedawson 2016/03/07 21:17:07 D'oh! Done. Show quoted text On 2016/03/07 20:32:36, scottmg (afk mar2-4) wrote: > This should be in the libxml readme, not the libxslt one? D'oh! Done.
	38 and "#endif around the #define of snprintf.

37	39

38 Remove:	40 Remove:

39 doc/	41 doc/

40 examples/	42 examples/

41 python/	43 python/

42 tests/	44 tests/

43 vms/	45 vms/

OLD	NEW

« no previous file with comments | « third_party/libxml/win32/config.h ('k') | no next file » | no next file with comments »