Pull AsyncApiFunction out of src/chrome

Pull AsyncApiFunction out of src/chrome

AsyncApiFunction now inherits UIThreadExtensionFunction directly, rather
than depending on ChromeAsyncExtensionFunction. It's also been moved from
chrome/browser/extensions/api/api_function.{h,cc} to
extensions/browser/api/async_api_function.{h,cc}.

With the exception of notifications API functions, anything which previously
depended on AsyncApiFunction's inheritance of ChromeAsyncExtensionFunction
was doing so only for GetProfile. In all cases, GetProfile() has been replaced
with ExtensionFunction::browser_context() (renamed from context()).

Finally, ApiFunction has been removed since it was identical to
ChromeAsyncExtensionFunction.

BUG=346949
TBR=dmazzoni@chromium.org,mfoltz@chromium.org,fgorski@chromium.org,courage@chromium.org,dewittj@chromium.org,rpaquay@chromium.org,kalman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254113

[Ken Rockot(use gerrit already), 2014-02-26 01:38:36]

This should help a few APIs move out, including sockets.*

[James Cook, 2014-02-26 17:57:21]

LGTM with nits, but you might want to run it by someone with more familiarity
with the extension function system (yoz? miket?)

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.cc (right):

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth/bluetooth_api.cc:139: if
(GetEventRouter(context())->HasProfile(uuid_)) {
Not for this CL, but I think the API code would be clearer if context() was
renamed browser_context().

Totally optional, but you could introduce a duplicate browser_context() method
in this CL and convert GetProfile() -> browser_context().  It might make it
easier to find the methods to change (easier to search for GetProfile than for
"context").

Up to you.

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc (right):

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc:46:
ExtensionBluetoothEventRouter::ExtensionBluetoothEventRouter(
These conversions seem awfully familiar, and similar to what yoz is doing in
https://codereview.chromium.org/179243002/

Are you up to date with his latest Profile -> BrowserContext conversions?

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
File extensions/browser/api/async_api_function.cc (right):

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
extensions/browser/api/async_api_function.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
ditto

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
File extensions/browser/api/async_api_function.h (right):

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
extensions/browser/api/async_api_function.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
nit: I don't think we update the copyright date for file renames. Unless you
consider this a new file.

[Ken Rockot(use gerrit already), 2014-02-26 18:20:44]

I spoke with kalman@ about it offline and I think this is good. Adding yoz@ for
a second opinion and also to verify my claims about overlap/conflicts with his
CL.

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.cc (right):

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth/bluetooth_api.cc:139: if
(GetEventRouter(context())->HasProfile(uuid_)) {
On 2014/02/26 17:57:21, James Cook wrote:
> Not for this CL, but I think the API code would be clearer if context() was
> renamed browser_context().
> 
> Totally optional, but you could introduce a duplicate browser_context() method
> in this CL and convert GetProfile() -> browser_context().  It might make it
> easier to find the methods to change (easier to search for GetProfile than for
> "context").
> 
> Up to you.

I agree with browser_context. As it turns out, a rename only affected a handful
of call sites outside this CL, so I just renamed it. I'd rather not leave a
deprecated context() around for people to continue using unawares.

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc (right):

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc:46:
ExtensionBluetoothEventRouter::ExtensionBluetoothEventRouter(
On 2014/02/26 17:57:21, James Cook wrote:
> These conversions seem awfully familiar, and similar to what yoz is doing in
> https://codereview.chromium.org/179243002/
> 
> Are you up to date with his latest Profile -> BrowserContext conversions?

Adding yoz to take a look. I see some conflict, but no duplicate effort. He's
adding profile.h to this impls so they can pass Profiles as BrowserContexts,
whereas I'm changing the call sites to pass browser_context() instead of
GetProfile().

I can wait until https://codereview.chromium.org/179243002 lands, clean this up,
and then land it.

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
File extensions/browser/api/async_api_function.cc (right):

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
extensions/browser/api/async_api_function.cc:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2014/02/26 17:57:21, James Cook wrote:
> ditto

Done.

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
File extensions/browser/api/async_api_function.h (right):

https://codereview.chromium.org/177003015/diff/1/extensions/browser/api/async...
extensions/browser/api/async_api_function.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2014/02/26 17:57:21, James Cook wrote:
> nit: I don't think we update the copyright date for file renames. Unless you
> consider this a new file.

I was considering it to be a new file, but I guess it hasn't changed much.
Reverted to 2012.

[Ken Rockot(use gerrit already), 2014-02-26 19:06:01]

OK, I've rebased since yoz@'s change landed.

[Yoyo Zhou, 2014-02-27 00:08:51]

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc (right):

https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc:46:
ExtensionBluetoothEventRouter::ExtensionBluetoothEventRouter(
On 2014/02/26 18:20:44, Ken Rockot wrote:
> On 2014/02/26 17:57:21, James Cook wrote:
> > These conversions seem awfully familiar, and similar to what yoz is doing in
> > https://codereview.chromium.org/179243002/
> > 
> > Are you up to date with his latest Profile -> BrowserContext conversions?
> 
> Adding yoz to take a look. I see some conflict, but no duplicate effort. He's
> adding profile.h to this impls so they can pass Profiles as BrowserContexts,
> whereas I'm changing the call sites to pass browser_context() instead of
> GetProfile().
> 
> I can wait until https://codereview.chromium.org/179243002 lands, clean this
up,
> and then land it.

https://codereview.chromium.org/168253002/ does conflict with some of the stuff
in this CL, though not this one. You'd have to look on a file-by-file basis to
make sure which, I'm afraid.

[Yoyo Zhou, 2014-02-27 00:11:58]

On 2014/02/27 00:08:51, Yoyo Zhou wrote:
>
https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
> File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc
(right):
> 
>
https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
> chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc:46:
> ExtensionBluetoothEventRouter::ExtensionBluetoothEventRouter(
> On 2014/02/26 18:20:44, Ken Rockot wrote:
> > On 2014/02/26 17:57:21, James Cook wrote:
> > > These conversions seem awfully familiar, and similar to what yoz is doing
in
> > > https://codereview.chromium.org/179243002/
> > > 
> > > Are you up to date with his latest Profile -> BrowserContext conversions?
> > 
> > Adding yoz to take a look. I see some conflict, but no duplicate effort.
He's
> > adding profile.h to this impls so they can pass Profiles as BrowserContexts,
> > whereas I'm changing the call sites to pass browser_context() instead of
> > GetProfile().
> > 
> > I can wait until https://codereview.chromium.org/179243002 lands, clean this
> up,
> > and then land it.
> 
> https://codereview.chromium.org/168253002/ does conflict with some of the
stuff
> in this CL, though not this one. You'd have to look on a file-by-file basis to
> make sure which, I'm afraid.

To elaborate on this, that change just deletes the *_factory.{cc,h} files.
Unfortunately, I just noticed that it doesn't change the constructors to take
BrowserContext* instead of Profile* (oops, looks like I need to fix that). I can
do so with the minimal change of initializing the Profile* profile_ with
Profile::FromBrowserContext(context).

[Ken Rockot(use gerrit already), 2014-02-27 22:01:50]

On 2014/02/27 00:11:58, Yoyo Zhou wrote:
> On 2014/02/27 00:08:51, Yoyo Zhou wrote:
> >
>
https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
> > File chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc
> (right):
> > 
> >
>
https://codereview.chromium.org/177003015/diff/1/chrome/browser/extensions/ap...
> > chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc:46:
> > ExtensionBluetoothEventRouter::ExtensionBluetoothEventRouter(
> > On 2014/02/26 18:20:44, Ken Rockot wrote:
> > > On 2014/02/26 17:57:21, James Cook wrote:
> > > > These conversions seem awfully familiar, and similar to what yoz is
doing
> in
> > > > https://codereview.chromium.org/179243002/
> > > > 
> > > > Are you up to date with his latest Profile -> BrowserContext
conversions?
> > > 
> > > Adding yoz to take a look. I see some conflict, but no duplicate effort.
> He's
> > > adding profile.h to this impls so they can pass Profiles as
BrowserContexts,
> > > whereas I'm changing the call sites to pass browser_context() instead of
> > > GetProfile().
> > > 
> > > I can wait until https://codereview.chromium.org/179243002 lands, clean
this
> > up,
> > > and then land it.
> > 
> > https://codereview.chromium.org/168253002/ does conflict with some of the
> stuff
> > in this CL, though not this one. You'd have to look on a file-by-file basis
to
> > make sure which, I'm afraid.
> 
> To elaborate on this, that change just deletes the *_factory.{cc,h} files.
> Unfortunately, I just noticed that it doesn't change the constructors to take
> BrowserContext* instead of Profile* (oops, looks like I need to fix that). I
can
> do so with the minimal change of initializing the Profile* profile_ with
> Profile::FromBrowserContext(context).

Should be alright now

[James Cook, 2014-02-27 22:16:00]

Another quick read, still LGTM

https://codereview.chromium.org/177003015/diff/120001/extensions/browser/exte...
File extensions/browser/extension_function.h (right):

https://codereview.chromium.org/177003015/diff/120001/extensions/browser/exte...
extensions/browser/extension_function.h:308: content::BrowserContext*
browser_context() const { return context_; }
Hooray!

[Yoyo Zhou, 2014-02-27 23:53:45]

LGTM

https://codereview.chromium.org/177003015/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/api/dial/dial_api_factory.h (right):

https://codereview.chromium.org/177003015/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/dial/dial_api_factory.h:18:
content::BrowserContext* profile);
nit: context

https://codereview.chromium.org/177003015/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/api/serial/serial_api.h (right):

https://codereview.chromium.org/177003015/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/serial/serial_api.h:82: // or its ownership is
transferred to the browser context's.
nit: the 's here looks extraneous

[Ken Rockot(use gerrit already), 2014-02-28 00:00:31]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-28 00:03:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/177003015/140001

[commit-bot: I haz the power, 2014-02-28 00:45:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 00:45:48]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, gfx_unittests,
google_apis_unittests, gpu_unittests, installer_util_unittests, ipc_tests,
jingle_unittests, media_unittests, mini_installer_test, nacl_integration,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Try jobs failed on following builders: linux_chromium_rel,
mac_chromium_compile_dbg

[Ken Rockot(use gerrit already), 2014-02-28 01:33:27]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-28 01:34:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/177003015/160001

[commit-bot: I haz the power, 2014-02-28 02:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 02:40:00]

Retried try job too often on win_x64_rel for step(s) base_unittests,
chrome_elf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[Ken Rockot(use gerrit already), 2014-02-28 03:03:48]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-02-28 03:03:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/177003015/160001

[commit-bot: I haz the power, 2014-02-28 03:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 03:57:15]

Retried try job too often on win_x64_rel for step(s) base_unittests,
chrome_elf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[James Cook, 2014-02-28 04:15:35]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-02-28 04:15:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/177003015/160001

[commit-bot: I haz the power, 2014-02-28 15:06:48]

Change committed as 254113