Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179243002: Change ProfileKeyedAPIFactory to build instances with BrowserContext instead of Profile. (Closed)

Created:
6 years, 10 months ago by Yoyo Zhou
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change ProfileKeyedAPIFactory to build instances with BrowserContext instead of Profile. This also updates a few call sites that were missed earlier, and it includes profile.h where it was previously gotten transitively. Follows https://chromiumcodereview.appspot.com/166053003/ and https://chromiumcodereview.appspot.com/174513003/ BUG=309909 TBR=dtseng@chromium.org,derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253509

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : locationbarview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -40 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_diagnosis_runner.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/screenlock_private_api.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/screenlock_private_api.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/api_resource_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/audio/audio_api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/cast_channel/cast_channel_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/commands/commands.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/hid/hid_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/location/location_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/messaging/incognito_connectability.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/profile_keyed_api_factory.h View 1 4 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_event_dispatcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_web_contents_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/signin/scoped_gaia_auth_extension.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/signin/scoped_gaia_auth_extension.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Yoyo Zhou
jamescook: this is the last change that is more than just renaming. Let me know ...
6 years, 10 months ago (2014-02-25 02:24:20 UTC) #1
Daniel Erat
lgtm for c/b/chromeos
6 years, 10 months ago (2014-02-25 03:11:07 UTC) #2
James Cook
LGTM! https://codereview.chromium.org/179243002/diff/20001/chrome/browser/extensions/api/profile_keyed_api_factory.h File chrome/browser/extensions/api/profile_keyed_api_factory.h (left): https://codereview.chromium.org/179243002/diff/20001/chrome/browser/extensions/api/profile_keyed_api_factory.h#oldcode9 chrome/browser/extensions/api/profile_keyed_api_factory.h:9: #include "chrome/browser/profiles/profile.h" Hooray for deleting these! https://codereview.chromium.org/179243002/diff/20001/chrome/browser/extensions/api/profile_keyed_api_factory.h File ...
6 years, 10 months ago (2014-02-25 17:59:15 UTC) #3
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-25 21:40:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/179243002/40001
6 years, 10 months ago (2014-02-25 21:42:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/179243002/40001
6 years, 10 months ago (2014-02-25 22:03:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/179243002/40001
6 years, 10 months ago (2014-02-25 22:31:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/179243002/40001
6 years, 10 months ago (2014-02-25 23:41:53 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 00:30:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-26 00:30:09 UTC) #10
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 10 months ago (2014-02-26 01:29:24 UTC) #11
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 04:41:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/179243002/60001
6 years, 10 months ago (2014-02-26 04:45:17 UTC) #13
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-26 05:27:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/179243002/60001
6 years, 10 months ago (2014-02-26 05:28:58 UTC) #15
commit-bot: I haz the power
Change committed as 253509
6 years, 10 months ago (2014-02-26 18:13:46 UTC) #16
Ryan Hamilton
6 years, 10 months ago (2014-02-26 18:57:29 UTC) #17
Message was sent while issue was closed. 
Looks like this broke the build

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Reverting.

Powered by Google App Engine
This is Rietveld 408576698