Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1769833003: Consolidate MPEG*_AAC_* MimeUtil::Codec enum values (Closed)

Created:
4 years, 9 months ago by ddorwin
Modified:
4 years, 9 months ago
Reviewers:
*chcunningham, servolk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate MPEG*_AAC_* MimeUtil::Codec enum values We don't differentiate between the profiles, so we do not need separate values. Also remove duplicate video codec strings from kFormatCodecMappings. BUG=591869 TEST=content_browsertests --gtest_filter=MediaCanPlayTypeTest* Committed: https://crrev.com/f52bd5bf94cf63512e6de19ad25181cabc641357 Cr-Commit-Position: refs/heads/master@{#380045}

Patch Set 1 : Just move the mp4a comments and remove the avc1 comments. #

Patch Set 2 : actual change #

Total comments: 4

Patch Set 3 : Update comment for 544268 and add comments to MP4 codecs expressions. #

Total comments: 2

Patch Set 4 : Consolidate comments about codec string variants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -82 lines) Patch
M content/browser/media/media_canplaytype_browsertest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/mime_util_internal.h View 1 1 chunk +2 lines, -6 lines 0 comments Download
M media/base/mime_util_internal.cc View 1 2 3 8 chunks +36 lines, -58 lines 0 comments Download
M media/base/mime_util_unittest.cc View 1 5 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ddorwin
PS1 shows the cut and paste of the comments for the audio comments (and the ...
4 years, 9 months ago (2016-03-07 18:38:55 UTC) #5
servolk
On 2016/03/07 18:38:55, ddorwin wrote: > PS1 shows the cut and paste of the comments ...
4 years, 9 months ago (2016-03-07 18:44:37 UTC) #6
servolk
https://codereview.chromium.org/1769833003/diff/20001/media/base/mime_util_internal.cc File media/base/mime_util_internal.cc (right): https://codereview.chromium.org/1769833003/diff/20001/media/base/mime_util_internal.cc#newcode46 media/base/mime_util_internal.cc:46: "avc1.42E00A," On 2016/03/07 18:38:55, ddorwin wrote: > The H264 ...
4 years, 9 months ago (2016-03-07 18:44:44 UTC) #7
chcunningham
lgtm https://codereview.chromium.org/1769833003/diff/40001/media/base/mime_util_internal.cc File media/base/mime_util_internal.cc (right): https://codereview.chromium.org/1769833003/diff/40001/media/base/mime_util_internal.cc#newcode38 media/base/mime_util_internal.cc:38: "mp4a.66,mp4a.69,mp4a.40.2"; // MPEG-2 AAC, MP3, and MPEG-4 AAC. ...
4 years, 9 months ago (2016-03-08 02:36:58 UTC) #8
ddorwin
https://codereview.chromium.org/1769833003/diff/40001/media/base/mime_util_internal.cc File media/base/mime_util_internal.cc (right): https://codereview.chromium.org/1769833003/diff/40001/media/base/mime_util_internal.cc#newcode38 media/base/mime_util_internal.cc:38: "mp4a.66,mp4a.69,mp4a.40.2"; // MPEG-2 AAC, MP3, and MPEG-4 AAC. On ...
4 years, 9 months ago (2016-03-08 18:40:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769833003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769833003/60001
4 years, 9 months ago (2016-03-09 02:09:45 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-09 02:51:07 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 02:52:29 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f52bd5bf94cf63512e6de19ad25181cabc641357
Cr-Commit-Position: refs/heads/master@{#380045}

Powered by Google App Engine
This is Rietveld 408576698