content/browser/media/media_canplaytype_browsertest.cc - Issue 1769833003: Consolidate MPEG*_AAC_* MimeUtil::Codec enum values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/media_canplaytype_browsertest.cc

Issue 1769833003: Consolidate MPEG*_AAC_* MimeUtil::Codec enum values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Consolidate comments about codec string variants. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/media/media_canplaytype_browsertest.cc

diff --git a/content/browser/media/media_canplaytype_browsertest.cc b/content/browser/media/media_canplaytype_browsertest.cc

index 5639d6d82784aed3dbb490878a6cca1aa5323eaa..e1fa4922c14c3a15470d5b2052c9ca191b6f8fe9 100644

--- a/content/browser/media/media_canplaytype_browsertest.cc

+++ b/content/browser/media/media_canplaytype_browsertest.cc

@@ -1162,9 +1162,11 @@ IN_PROC_BROWSER_TEST_F(MediaCanPlayTypeTest, CodecSupportTest_Mp4aVariants) {

// See http://crbug.com/440607.

EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"mp4a.40.00\"'"));

EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"mp4a.40.01\"'"));

+ // MPEG4 AAC LC.

EXPECT_EQ(kPropProbably, CanPlay("'audio/mp4; codecs=\"mp4a.40.02\"'"));

EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"mp4a.40.03\"'"));

EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"mp4a.40.04\"'"));

+ // MPEG4 AAC SBR v1.

EXPECT_EQ(kPropProbably, CanPlay("'audio/mp4; codecs=\"mp4a.40.05\"'"));

EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"mp4a.40.029\"'"));

« no previous file with comments | « no previous file | media/base/mime_util_internal.h » ('j') | no next file with comments »