Doc server: support interfaces in src/extensions

Doc server: support interfaces in src/extensions

This adds primitive support to the doc server for
API models living in src/extensions/common/api.

BUG=349953
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255629

[Ken Rockot(use gerrit already), 2014-03-06 17:35:33]

Please take a look

[not at google - send to devlin, 2014-03-06 22:16:20]

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/api_models.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/api_models.py:48: if not
api_name.startswith(API):
I guess this isn't a problem yet? I think it may become one at some point. You
might as well deal with it now. I.e. handle both API and CORE_API here.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/api_models_test.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/api_models_test.py:123: # 2 stats (1 for
JSON and 1 for IDL), 1 read (for IDL file which existed).
update this comment.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/api_models_test.py:139:
self.assertTrue(*self._mock_file_system.CheckAndReset(stat_count=4))
and this one.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/availability_finder.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/availability_finder.py:32: feature =
json_fs.GetFromFile(API + filename).Get().get(api_name)
bleh, let's update these functions to take the actual path directly, like
API_FEATURES and MANIFEST_FEATURES etc constants, which are already defined.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/extensions_paths.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/extensions_paths.py:13: CORE_API =
'extensions/common/api/'
so - from the context of this CL I know what these mean. but in general I'd be a
bit confused.

my point being, could you rename API to CHROME_API?

it's actually not that many occurrences, and the one in api_data_source.py can
be deleted.

also a quick comment explaning the difference here wouldbe nice.

[Ken Rockot(use gerrit already), 2014-03-06 23:55:16]

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/api_models.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/api_models.py:48: if not
api_name.startswith(API):
On 2014/03/06 22:16:21, kalman wrote:
> I guess this isn't a problem yet? I think it may become one at some point. You
> might as well deal with it now. I.e. handle both API and CORE_API here.

Done.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/api_models_test.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/api_models_test.py:123: # 2 stats (1 for
JSON and 1 for IDL), 1 read (for IDL file which existed).
On 2014/03/06 22:16:21, kalman wrote:
> update this comment.

Done.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/api_models_test.py:139:
self.assertTrue(*self._mock_file_system.CheckAndReset(stat_count=4))
On 2014/03/06 22:16:21, kalman wrote:
> and this one.

Done.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/availability_finder.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/availability_finder.py:32: feature =
json_fs.GetFromFile(API + filename).Get().get(api_name)
On 2014/03/06 22:16:21, kalman wrote:
> bleh, let's update these functions to take the actual path directly, like
> API_FEATURES and MANIFEST_FEATURES etc constants, which are already defined.

Done.

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/server2/extensions_paths.py (right):

https://codereview.chromium.org/176973009/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/server2/extensions_paths.py:13: CORE_API =
'extensions/common/api/'
On 2014/03/06 22:16:21, kalman wrote:
> so - from the context of this CL I know what these mean. but in general I'd be
a
> bit confused.
> 
> my point being, could you rename API to CHROME_API?
> 
> it's actually not that many occurrences, and the one in api_data_source.py can
> be deleted.
> 
> also a quick comment explaning the difference here wouldbe nice.

Yes, I agree, but I think CORE_API should also become API. Done, so let me know
what you think. I also made the same change for the base paths (i.e. EXTENSIONS
is now 'extensions/common' and CHROME_EXTENSIONS is 'chrome/common/extensions').

I think changing the base path constants eliminates any need for explanatory
comments, but please let me know if you disagree.

[not at google - send to devlin, 2014-03-07 01:04:52]

lgtm

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/api_models.py (left):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:23: 
this is actually python style [guide] apparently

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/api_models.py (right):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:47: if not
api_name.startswith(API) and not api_name.startswith(CHROME_API):
if not api_name.startswith((API, CHROME_API)):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:49: if
self._model_cache.FileExists(api_path).Get():
rather than adding a new method here, hold onto |file_system| and do
self._file_system.Exists(api_path).Get()

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:54: assert not
api_name.startswith(API) and not api_name.startswith(CHROME_API)
ditto

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/compiled_file_system.py (right):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/compiled_file_system.py:263: def
FileExists(self, path):
see elsewhere-comment about not needing this function

[Ken Rockot(use gerrit already), 2014-03-07 07:07:09]

gracias

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/api_models.py (left):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:23: 
On 2014/03/07 01:04:52, kalman wrote:
> this is actually python style [guide] apparently

Done.

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/api_models.py (right):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:47: if not
api_name.startswith(API) and not api_name.startswith(CHROME_API):
On 2014/03/07 01:04:52, kalman wrote:
> if not api_name.startswith((API, CHROME_API)):

Done.

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:49: if
self._model_cache.FileExists(api_path).Get():
On 2014/03/07 01:04:52, kalman wrote:
> rather than adding a new method here, hold onto |file_system| and do
> self._file_system.Exists(api_path).Get()

Done.

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/api_models.py:54: assert not
api_name.startswith(API) and not api_name.startswith(CHROME_API)
On 2014/03/07 01:04:52, kalman wrote:
> ditto

Done.

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/server2/compiled_file_system.py (right):

https://codereview.chromium.org/176973009/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/server2/compiled_file_system.py:263: def
FileExists(self, path):
On 2014/03/07 01:04:52, kalman wrote:
> see elsewhere-comment about not needing this function

Done.

[Ken Rockot(use gerrit already), 2014-03-07 07:07:16]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-03-07 07:09:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/176973009/40001

[commit-bot: I haz the power, 2014-03-07 07:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 07:30:40]

Try jobs failed on following builders: mac_chromium_compile_dbg

[Ken Rockot(use gerrit already), 2014-03-07 15:33:22]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-03-07 15:34:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rockot@chromium.org/176973009/40001

[commit-bot: I haz the power, 2014-03-07 16:12:27]

Change committed as 255629