chrome/common/extensions/docs/server2/extensions_paths.py - Issue 176973009: Doc server: support interfaces in src/extensions

Side by Side Diff: chrome/common/extensions/docs/server2/extensions_paths.py

Issue 176973009: Doc server: support interfaces in src/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/docs/server2/availability_finder.py ('K') | « chrome/common/extensions/docs/server2/cron.yaml ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from posixpath import join	5 from posixpath import join

6	6

7	7

8 # Extensions-related paths within the Chromium repository.	8 # Extensions-related paths within the Chromium repository.

9	9

10 EXTENSIONS = 'chrome/common/extensions/'	10 EXTENSIONS = 'chrome/common/extensions/'

11	11

12 API = join(EXTENSIONS, 'api/')	12 API = join(EXTENSIONS, 'api/')

	13 CORE_API = 'extensions/common/api/'
	not at google - send to devlin 2014/03/06 22:16:21 so - from the context of this CL I know what these so - from the context of this CL I know what these mean. but in general I'd be a bit confused. my point being, could you rename API to CHROME_API? it's actually not that many occurrences, and the one in api_data_source.py can be deleted. also a quick comment explaning the difference here wouldbe nice. Ken Rockot(use gerrit already) 2014/03/06 23:55:16 Yes, I agree, but I think CORE_API should also bec Show quoted text On 2014/03/06 22:16:21, kalman wrote: > so - from the context of this CL I know what these mean. but in general I'd be a > bit confused. > > my point being, could you rename API to CHROME_API? > > it's actually not that many occurrences, and the one in api_data_source.py can > be deleted. > > also a quick comment explaning the difference here wouldbe nice. Yes, I agree, but I think CORE_API should also become API. Done, so let me know what you think. I also made the same change for the base paths (i.e. EXTENSIONS is now 'extensions/common' and CHROME_EXTENSIONS is 'chrome/common/extensions'). I think changing the base path constants eliminates any need for explanatory comments, but please let me know if you disagree.
13 DOCS = join(EXTENSIONS, 'docs/')	14 DOCS = join(EXTENSIONS, 'docs/')

14	15

15 API_FEATURES = join(API, '_api_features.json')	16 API_FEATURES = join(API, '_api_features.json')

16 MANIFEST_FEATURES = join(API, '_manifest_features.json')	17 MANIFEST_FEATURES = join(API, '_manifest_features.json')

17 PERMISSION_FEATURES = join(API, '_permission_features.json')	18 PERMISSION_FEATURES = join(API, '_permission_features.json')

18	19

19 EXAMPLES = join(DOCS, 'examples/')	20 EXAMPLES = join(DOCS, 'examples/')

20 SERVER2 = join(DOCS, 'server2/')	21 SERVER2 = join(DOCS, 'server2/')

21 STATIC_DOCS = join(DOCS, 'static/')	22 STATIC_DOCS = join(DOCS, 'static/')

22 TEMPLATES = join(DOCS, 'templates/')	23 TEMPLATES = join(DOCS, 'templates/')

23	24

24 APP_YAML = join(SERVER2, 'app.yaml')	25 APP_YAML = join(SERVER2, 'app.yaml')

25	26

26 ARTICLES_TEMPLATES = join(TEMPLATES, 'articles/')	27 ARTICLES_TEMPLATES = join(TEMPLATES, 'articles/')

27 INTROS_TEMPLATES = join(TEMPLATES, 'intros/')	28 INTROS_TEMPLATES = join(TEMPLATES, 'intros/')

28 JSON_TEMPLATES = join(TEMPLATES, 'json/')	29 JSON_TEMPLATES = join(TEMPLATES, 'json/')

29 PRIVATE_TEMPLATES = join(TEMPLATES, 'private/')	30 PRIVATE_TEMPLATES = join(TEMPLATES, 'private/')

30 PUBLIC_TEMPLATES = join(TEMPLATES, 'public/')	31 PUBLIC_TEMPLATES = join(TEMPLATES, 'public/')

31	32

32 CONTENT_PROVIDERS = join(JSON_TEMPLATES, 'content_providers.json')	33 CONTENT_PROVIDERS = join(JSON_TEMPLATES, 'content_providers.json')

33	34

34 LOCAL_DEBUG_DIR = join(SERVER2, 'local_debug/')	35 LOCAL_DEBUG_DIR = join(SERVER2, 'local_debug/')

35 LOCAL_GCS_DIR = join(LOCAL_DEBUG_DIR, 'gcs/')	36 LOCAL_GCS_DIR = join(LOCAL_DEBUG_DIR, 'gcs/')

36 LOCAL_GCS_DEBUG_CONF = join(LOCAL_DEBUG_DIR, 'gcs_debug.conf')	37 LOCAL_GCS_DEBUG_CONF = join(LOCAL_DEBUG_DIR, 'gcs_debug.conf')

OLD	NEW