Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 176963017: Remove WrapperWorldType from V8 binding (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove WrapperWorldType from V8 binding - Now that domTemplate() is always used for the current world, this CL removes a WrapperWorldType parameter from domTemplate(). Alternaltely, domTemplate() looks up the current world inside domTemplate(). - Now that DOMConfiguration methods are always used for the current world, this CL removes a WrapperWorldType parameter from the DOMConfiguration methods. Alternaltely, the methods look up the current world inside the methods. - This CL removes WrapperWorldType, worldType() and worldTypeInMainThread() completely. BUG=341032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168978

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -468 lines) Patch
M Source/bindings/templates/interface.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 12 chunks +23 lines, -24 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 15 chunks +20 lines, -26 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 3 chunks +12 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 4 chunks +11 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 4 chunks +11 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 1 2 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 3 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 5 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsCustom.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.h View 1 2 1 chunk +4 lines, -9 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 1 chunk +0 lines, -19 lines 0 comments Download
M Source/bindings/v8/V8DOMConfiguration.h View 2 chunks +5 lines, -16 lines 0 comments Download
M Source/bindings/v8/V8DOMConfiguration.cpp View 4 chunks +12 lines, -10 lines 0 comments Download
M Source/bindings/v8/V8DOMWrapper.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8PerContextData.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8PerIsolateData.h View 1 2 chunks +5 lines, -12 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 1 2 chunks +13 lines, -6 lines 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/WrapperTypeInfo.h View 2 chunks +5 lines, -8 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8TypedArrayCustom.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
haraken
PTAL I'm planning to make a couple of clean-ups in a follow-up CL. To make ...
6 years, 10 months ago (2014-02-26 13:01:40 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-26 14:27:08 UTC) #2
haraken
On 2014/02/26 14:27:08, dcarney wrote: > lgtm Thanks, I'll take a look at bot failures ...
6 years, 10 months ago (2014-02-26 14:36:08 UTC) #3
haraken
I think it's now safe to land this CL. Landing.
6 years, 9 months ago (2014-03-11 05:09:12 UTC) #4
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-11 05:09:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176963017/20001
6 years, 9 months ago (2014-03-11 05:09:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 05:48:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-11 05:48:18 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-11 09:11:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176963017/20001
6 years, 9 months ago (2014-03-11 09:12:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 09:52:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-11 09:52:12 UTC) #12
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-12 01:18:49 UTC) #13
haraken
Fixed test failures on bots. I changed DOMWrapperWorld.h a bit.
6 years, 9 months ago (2014-03-12 01:19:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176963017/40001
6 years, 9 months ago (2014-03-12 01:22:13 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 01:26:01 UTC) #16
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 9 months ago (2014-03-12 01:26:01 UTC) #17
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-12 01:28:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/176963017/40001
6 years, 9 months ago (2014-03-12 01:28:33 UTC) #19
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 06:04:35 UTC) #20
Message was sent while issue was closed.
Change committed as 168978

Powered by Google App Engine
This is Rietveld 408576698