media/formats/webm/webm_video_client.cc - Issue 1769593002: Add 4 VP9 profiles to the media::VideoCodecProfile enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_video_client.cc

Issue 1769593002: Add 4 VP9 profiles to the media::VideoCodecProfile enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hevc-codec-7

Patch Set: Added some comments and dchecks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/webm/webm_video_client.cc

diff --git a/media/formats/webm/webm_video_client.cc b/media/formats/webm/webm_video_client.cc

index 9d0435f051dca2b1b80e8bca4f522a6ac450c03a..73bd095b854b73afd57276d232e7032cd3c4b543 100644

--- a/media/formats/webm/webm_video_client.cc

+++ b/media/formats/webm/webm_video_client.cc

@@ -44,7 +44,9 @@ bool WebMVideoClient::InitializeConfig(

profile = VP8PROFILE_ANY;

} else if (codec_id == "V_VP9") {

video_codec = kCodecVP9;

- profile = VP9PROFILE_ANY;

+ // TODO(servolk): Find a way to read actual VP9 profile from WebM.

+ // crbug.com/592074

+ profile = VP9PROFILE_PROFILE0;

} else {

MEDIA_LOG(ERROR, media_log_) << "Unsupported video codec_id " << codec_id;

return false;

« no previous file with comments | « media/ffmpeg/ffmpeg_common.cc ('k') | media/mojo/common/media_type_converters.cc » ('j') | no next file with comments »