media/ffmpeg/ffmpeg_common.cc - Issue 1769593002: Add 4 VP9 profiles to the media::VideoCodecProfile enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/ffmpeg/ffmpeg_common.cc

Issue 1769593002: Add 4 VP9 profiles to the media::VideoCodecProfile enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hevc-codec-7

Patch Set: Added some comments and dchecks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/ffmpeg/ffmpeg_common.cc

diff --git a/media/ffmpeg/ffmpeg_common.cc b/media/ffmpeg/ffmpeg_common.cc

index f0812552ec4f0d943c496fd89be87bbc90733268..f584141ebb91e79c2575f5b77243e2c1c1a718da 100644

--- a/media/ffmpeg/ffmpeg_common.cc

+++ b/media/ffmpeg/ffmpeg_common.cc

@@ -461,7 +461,9 @@ bool AVStreamToVideoDecoderConfig(const AVStream* stream,

if (codec == kCodecVP8)

profile = VP8PROFILE_ANY;

else if (codec == kCodecVP9)

- profile = VP9PROFILE_ANY;

+ // TODO(servolk): Find a way to obtain actual VP9 profile from FFmpeg.

+ // crbug.com/592074

+ profile = VP9PROFILE_PROFILE0;

else

profile = ProfileIDToVideoCodecProfile(stream->codec->profile);

« no previous file with comments | « media/cdm/cdm_adapter.cc ('k') | media/formats/webm/webm_video_client.cc » ('j') | no next file with comments »