Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 1769553003: Guard against division by zero for useless scroll bars. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Guard against division by zero for useless scroll bars. This patch adds protection against division by zero when a scroll bar's thumb is the full size of the track (i.e. the scroll bar is useless). BUG=591933 Committed: https://crrev.com/5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8 Cr-Commit-Position: refs/heads/master@{#379437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/scrollbar_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 9 months ago (2016-03-04 18:56:13 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-04 21:02:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769553003/1
4 years, 9 months ago (2016-03-04 21:09:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/184394)
4 years, 9 months ago (2016-03-04 22:40:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769553003/1
4 years, 9 months ago (2016-03-05 02:17:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 02:23:47 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 02:25:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c6639a0a0b75d2696f6b3c9a5a47c8dc6096df8
Cr-Commit-Position: refs/heads/master@{#379437}

Powered by Google App Engine
This is Rietveld 408576698