ui/views/controls/scrollbar/base_scroll_bar.h - Issue 1769553003: Guard against division by zero for useless scroll bars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/scrollbar/base_scroll_bar.h

Issue 1769553003: Guard against division by zero for useless scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/scrollbar/base_scroll_bar.h

diff --git a/ui/views/controls/scrollbar/base_scroll_bar.h b/ui/views/controls/scrollbar/base_scroll_bar.h

index f54a88081786aea444617189a6ba477bfc16e837..178fdc1e9081a2a00551a01713028a18981e703f 100644

--- a/ui/views/controls/scrollbar/base_scroll_bar.h

+++ b/ui/views/controls/scrollbar/base_scroll_bar.h

@@ -115,6 +115,7 @@ class VIEWS_EXPORT BaseScrollBar : public ScrollBar,

private:

FRIEND_TEST_ALL_PREFIXES(NativeScrollBarTest, ScrollBarFitsToBottom);

+ FRIEND_TEST_ALL_PREFIXES(NativeScrollBarTest, ThumbFullLengthOfTrack);

int GetThumbSizeForTest();

// Changes to 'pushed' state and starts a timer to scroll repeatedly.

« no previous file with comments | « no previous file | ui/views/controls/scrollbar/base_scroll_bar.cc » ('j') | no next file with comments »