Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1769493002: Remove SVGUseElement::buildShadowTree (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-useelm-shadowbuilder-cleanup-9
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGUseElement::buildShadowTree SVGUseElement::buildShadowTree() steps out for a moment to regain strength. In its absence, open-code the sequence using other helper functions. BUG=589682 Committed: https://crrev.com/bb6c8ea4087b7759e075b3300148e6ea7e482a8e Cr-Commit-Position: refs/heads/master@{#379290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -51 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 4 chunks +29 lines, -50 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-04 14:40:21 UTC) #2
Stephen Chennney
LGTM.
4 years, 9 months ago (2016-03-04 15:39:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769493002/1
4 years, 9 months ago (2016-03-04 15:48:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 15:53:11 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:54:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb6c8ea4087b7759e075b3300148e6ea7e482a8e
Cr-Commit-Position: refs/heads/master@{#379290}

Powered by Google App Engine
This is Rietveld 408576698