Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1763033002: Add SVGUseElement::createInstanceTree helper (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-useelm-shadowbuilder-cleanup-10
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SVGUseElement::createInstanceTree helper Add a new method used to create a new instance subtree from a <use>- targetted element. Re-use where possible. Also make isDisallowedElement(...) take a Element& (it's no longer called on Nodes) and remove a redundant call to removeDisallowedElementsFromSubtree in <symbol> expansion (no new clones are produced here expecpt the <svg> on replacing the <symbol>.) BUG=589682 Committed: https://crrev.com/8a99876d324ea81915ad034e351c3154e77e43ba Cr-Commit-Position: refs/heads/master@{#379298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 5 chunks +13 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-04 15:56:25 UTC) #2
Stephen Chennney
LGTM
4 years, 9 months ago (2016-03-04 16:00:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1763033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1763033002/1
4 years, 9 months ago (2016-03-04 16:18:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 16:23:54 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:25:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a99876d324ea81915ad034e351c3154e77e43ba
Cr-Commit-Position: refs/heads/master@{#379298}

Powered by Google App Engine
This is Rietveld 408576698