Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 176943005: Revert 167841 "Revert 167826 "Rename text track methods to make ..." (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Visibility:
Public.

Description

Revert 167841 "Revert 167826 "Rename text track methods to make ..." This is a revert of the revert. r167826 was not a culprit of the test breakage in Linux bots. > Revert 167826 "Rename text track methods to make way for audio &..." > > This CL broke a lot of Media tests and Track tests in Linux bots. > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032 > > > Rename text track methods to make way for audio & video tracks. > > > > - Rename various text track related methods to explicitly indicate that > > they apply to text tracks. This is to avoid confusion when audio & > > video track logic is landed. > > > > - Renamed TextTrackList::clearOwner() to clearOwnerAndClients() and moved > > some the client clearing out of HTMLMediaElement and into TextTrackList. > > This doesn't introduce any change in behavior. It just restores some > > encapsulation. > > > > BUG=249427 > > TEST=All LayoutTests still pass. > > > > Review URL: https://codereview.chromium.org/180173002 > > TBR=acolwell@chromium.org > > Review URL: https://codereview.chromium.org/177213015 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M trunk/Source/core/html/HTMLMediaElement.h View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/Source/core/html/HTMLMediaElement.cpp View 12 chunks +16 lines, -19 lines 0 comments Download
M trunk/Source/core/html/HTMLTrackElement.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/Source/core/html/track/TextTrackList.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/track/TextTrackList.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M trunk/Source/platform/graphics/media/MediaPlayer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/web/WebMediaPlayerClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 10 months ago (2014-02-26 01:32:09 UTC) #1
haraken
6 years, 10 months ago (2014-02-26 01:32:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r167842.

Powered by Google App Engine
This is Rietveld 408576698