Issue 180173002: Rename text track methods to make way for audio & video tracks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180173002: Rename text track methods to make way for audio & video tracks. (Closed)

Created:
6 years, 10 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 10 months ago

Reviewers:
adamk

CC:
blink-reviews, jamesr, nessy, Rik, dsinclair, philipj_slow, gasubic, fs, eric.carlson_apple.com, jbroman, danakj, feature-media-reviews_chromium.org, dglazkov+blink, pdr., krit, adamk+blink_chromium.org, Stephen Chennney, vcarbune.chromium, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename text track methods to make way for audio & video tracks. - Rename various text track related methods to explicitly indicate that they apply to text tracks. This is to avoid confusion when audio & video track logic is landed. - Renamed TextTrackList::clearOwner() to clearOwnerAndClients() and moved some the client clearing out of HTMLMediaElement and into TextTrackList. This doesn't introduce any change in behavior. It just restores some encapsulation. BUG=249427 TEST=All LayoutTests still pass. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167826

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -33 lines)			Patch
M	Source/core/html/HTMLMediaElement.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	12 chunks	+16 lines, -19 lines	0 comments	Download
M	Source/core/html/HTMLTrackElement.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/html/track/TextTrackList.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/track/TextTrackList.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/platform/graphics/media/MediaPlayer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/180173002/1

6 years, 10 months ago (2014-02-25 18:36:56 UTC) #3

Message was sent while issue was closed.

Change committed as 167826

Expand Messages | Collapse Messages