Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp b/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
index e8277ba96d72a5f995b1a24f72397fa3d8e61a8b..c61d7a53dce607eee6ccb5559df08babc4f4cd4a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
@@ -32,14 +32,15 @@ v8::Local<v8::FunctionTemplate> InspectorWrapperBase::createWrapperTemplate(v8::
return functionTemplate;
}
-v8::Local<v8::Object> InspectorWrapperBase::createWrapper(V8DebuggerClient* client, v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context)
+v8::Local<v8::Object> InspectorWrapperBase::createWrapper(v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context)
{
v8::Local<v8::Function> function;
if (!constructorTemplate->GetFunction(context).ToLocal(&function))
return v8::Local<v8::Object>();
v8::Local<v8::Object> result;
- if (!client->instantiateObject(function).ToLocal(&result))
+ v8::MicrotasksScope microtasksScope(context->GetIsolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);
pfeldman 2016/03/08 01:44:20 We don't need microtasks around the injected scrip
dgozman 2016/03/08 02:23:00 Done.
+ if (!function->NewInstance(context).ToLocal(&result))
return v8::Local<v8::Object>();
return result;
}

Powered by Google App Engine
This is Rietveld 408576698