Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1769273002: Reland "Fix chromium-style errors." (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland "Fix chromium-style errors." This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/68b4a4abb713c97badbba54884a477564d41a139

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -124 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 9 chunks +30 lines, -42 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 7 chunks +7 lines, -19 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 5 chunks +15 lines, -17 lines 0 comments Download
M core/include/fxge/fx_dib.h View 7 chunks +5 lines, -26 lines 0 comments Download
M core/include/fxge/fx_font.h View 4 chunks +7 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 4 chunks +104 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_basic_util.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
A core/src/fxcrt/fxcrt_stream.cpp View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 5 chunks +32 lines, -8 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dsinclair
PTAL. See the diff between ps#1 and ps#2. Turns out there was no fx_stream.cpp for ...
4 years, 9 months ago (2016-03-08 14:10:07 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-08 18:33:19 UTC) #3
Tom Sepez
On 2016/03/08 18:33:19, Tom Sepez wrote: > lgtm Actually, not LGTM. Want to avoid duplicating ...
4 years, 9 months ago (2016-03-08 18:34:33 UTC) #4
dsinclair
Updated to core/src/fxcrt/fxcrt_stream.cpp which matches a few of the files in core/src/fxcrt.
4 years, 9 months ago (2016-03-08 18:47:57 UTC) #5
Tom Sepez
On 2016/03/08 18:47:57, dsinclair wrote: > Updated to core/src/fxcrt/fxcrt_stream.cpp which matches a few of the ...
4 years, 9 months ago (2016-03-08 19:29:09 UTC) #6
dsinclair
4 years, 9 months ago (2016-03-08 20:06:16 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
68b4a4abb713c97badbba54884a477564d41a139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698