Reland "Fix chromium-style errors."

core/src/fxcrt/fx_basic_buffer.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <algorithm>
 #include <limits>
 
 #include "core/include/fxcrt/fx_basic.h"
 #include "core/include/fxcrt/fx_safe_types.h"
 #include "third_party/base/numerics/safe_conversions.h"
 
 CFX_BinaryBuf::CFX_BinaryBuf()
     : m_AllocStep(0), m_AllocSize(0), m_DataSize(0) {}
 
 CFX_BinaryBuf::CFX_BinaryBuf(FX_STRSIZE size)
     : m_AllocStep(0), m_AllocSize(size), m_DataSize(size) {
   m_pBuffer.reset(FX_Alloc(uint8_t, size));
 }
 
+CFX_BinaryBuf::~CFX_BinaryBuf() {}
+
 void CFX_BinaryBuf::Delete(int start_index, int count) {
   if (!m_pBuffer || start_index < 0 || count < 0 || count > m_DataSize ||
       start_index > m_DataSize - count) {
     return;
   }
   FXSYS_memmove(m_pBuffer.get() + start_index,
                 m_pBuffer.get() + start_index + count,
                 m_DataSize - start_index - count);
   m_DataSize -= count;
 }
@@ skipping 325 matching lines @@
   if (bit_left) {
     result |= m_pData[byte_pos] >> (8 - bit_left);
   }
   m_BitPos += nBits;
   return result;
 }
 
 CFX_FileBufferArchive::CFX_FileBufferArchive()
     : m_Length(0), m_pFile(nullptr) {}
 
+CFX_FileBufferArchive::~CFX_FileBufferArchive() {}
+
 void CFX_FileBufferArchive::Clear() {
   m_Length = 0;
   m_pBuffer.reset();
   m_pFile = nullptr;
 }
 
 bool CFX_FileBufferArchive::Flush() {
   size_t nRemaining = m_Length;
   m_Length = 0;
   if (!m_pFile)
@@ skipping 38 matching lines @@
 }
 
 int32_t CFX_FileBufferArchive::AppendString(const CFX_ByteStringC& lpsz) {
   return AppendBlock(lpsz.GetPtr(), lpsz.GetLength());
 }
 
 void CFX_FileBufferArchive::AttachFile(IFX_StreamWrite* pFile) {
   FXSYS_assert(pFile);
   m_pFile = pFile;
 }