Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1769233002: Load host settings in connect_ to ensure they are valid for every connection. (Closed)

Created:
4 years, 9 months ago by Jamie
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Load host settings in connect_ to ensure they are valid for every connection. Previously, they were loaded only in start, which led to them being invalid for reconnections where a JID change required that the host_ member be refreshed. BUG=592068 Review URL: https://codereview.chromium.org/1765643003 Cr-Commit-Position: refs/heads/master@{#379414} (cherry picked from commit e2fe1ad65044e955bd7184b7b9597de2162a6294) Committed: https://chromium.googlesource.com/chromium/src/+/2ea40f3cc35b1b4782718e5b984dc0950ab2869d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M remoting/webapp/crd/js/me2me_activity.js View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jamie
4 years, 9 months ago (2016-03-07 21:19:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ea40f3cc35b1b4782718e5b984dc0950ab2869d.

Powered by Google App Engine
This is Rietveld 408576698