Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1765643003: Load host settings in connect_ to ensure they are valid for every connection. (Closed)

Created:
4 years, 9 months ago by Jamie
Modified:
4 years, 9 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Load host settings in connect_ to ensure they are valid for every connection. Previously, they were loaded only in start, which led to them being invalid for reconnections where a JID change required that the host_ member be refreshed. BUG=592068 Committed: https://crrev.com/e2fe1ad65044e955bd7184b7b9597de2162a6294 Cr-Commit-Position: refs/heads/master@{#379414}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M remoting/webapp/crd/js/me2me_activity.js View 2 chunks +9 lines, -6 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Jamie
ptal https://codereview.chromium.org/1765643003/diff/1/remoting/webapp/crd/js/me2me_activity.js File remoting/webapp/crd/js/me2me_activity.js (right): https://codereview.chromium.org/1765643003/diff/1/remoting/webapp/crd/js/me2me_activity.js#newcode217 remoting/webapp/crd/js/me2me_activity.js:217: that.host_ = host; This is the offending line. ...
4 years, 9 months ago (2016-03-04 19:46:24 UTC) #2
kelvinp
lgtm
4 years, 9 months ago (2016-03-04 23:56:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1765643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1765643003/1
4 years, 9 months ago (2016-03-04 23:56:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 00:34:15 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 00:36:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2fe1ad65044e955bd7184b7b9597de2162a6294
Cr-Commit-Position: refs/heads/master@{#379414}

Powered by Google App Engine
This is Rietveld 408576698