Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: runtime/vm/object_store.h

Issue 1769183003: Fix sticky error propagation from thread to isolate (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Allow only mutator thread to propagate sticky error Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_store.h
diff --git a/runtime/vm/object_store.h b/runtime/vm/object_store.h
index 92be955561599b0c55c3689fe4305c23b3f32d5f..ab2bd100f3712d51f605a0f1987e65d600ab5b53 100644
--- a/runtime/vm/object_store.h
+++ b/runtime/vm/object_store.h
@@ -365,6 +365,12 @@ class ObjectStore {
return error_listeners_;
}
+ // This sticky_error is used to preserve Thread::sticky_error_ after the
+ // mutator thread has been unscheduled.
+ RawError* sticky_error() const { return sticky_error_; }
+ void SetStickyErrorFromThread(const Thread* value);
Ivan Posva 2016/03/09 08:27:18 Now we are putting functionality into the ObjectSt
+ void clear_sticky_error() { sticky_error_ = Error::null(); }
+
RawContext* empty_context() const { return empty_context_; }
void set_empty_context(const Context& value) {
empty_context_ = value.raw();
@@ -554,6 +560,7 @@ class ObjectStore {
RawGrowableObjectArray* resume_capabilities_;
RawGrowableObjectArray* exit_listeners_;
RawGrowableObjectArray* error_listeners_;
+ RawError* sticky_error_;
RawContext* empty_context_;
RawInstance* stack_overflow_;
RawInstance* out_of_memory_;
« runtime/vm/isolate.cc ('K') | « runtime/vm/isolate.cc ('k') | runtime/vm/object_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698