Fix sticky error propagation from thread to isolate

runtime/vm/object_store.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_STORE_H_
 #define VM_OBJECT_STORE_H_
 
 #include "vm/object.h"
 
 namespace dart {
@@ skipping 347 matching lines @@
   }
 
   RawGrowableObjectArray* exit_listeners() const {
     return exit_listeners_;
   }
 
   RawGrowableObjectArray* error_listeners() const {
     return error_listeners_;
   }
 
+  // This sticky_error is used to preserve Thread::sticky_error_ after the
+  // mutator thread has been unscheduled.
+  RawError* sticky_error() const { return sticky_error_; }
+  void SetStickyErrorFromThread(const Thread* value);

[Ivan Posva, 2016/03/09 08:27:18]

Now we are putting functionality into the ObjectStore, please move this to
wherever this is being called. It is a single spot only as far as I can tell.

+  void clear_sticky_error() { sticky_error_ = Error::null(); }
+
   RawContext* empty_context() const { return empty_context_; }
   void set_empty_context(const Context& value) {
     empty_context_ = value.raw();
   }
 
   RawInstance* stack_overflow() const { return stack_overflow_; }
   void set_stack_overflow(const Instance& value) {
     stack_overflow_ = value.raw();
   }
 
@@ skipping 169 matching lines @@
   RawLibrary* root_library_;
   RawLibrary* typed_data_library_;
   RawLibrary* vmservice_library_;
   RawGrowableObjectArray* libraries_;
   RawGrowableObjectArray* closure_functions_;
   RawGrowableObjectArray* pending_classes_;
   RawGrowableObjectArray* pending_deferred_loads_;
   RawGrowableObjectArray* resume_capabilities_;
   RawGrowableObjectArray* exit_listeners_;
   RawGrowableObjectArray* error_listeners_;
+  RawError* sticky_error_;
   RawContext* empty_context_;
   RawInstance* stack_overflow_;
   RawInstance* out_of_memory_;
   RawUnhandledException* preallocated_unhandled_exception_;
   RawStacktrace* preallocated_stack_trace_;
   RawFunction* lookup_port_handler_;
   RawTypedData* empty_uint32_array_;
   RawFunction* handle_message_function_;
   RawArray* library_load_error_table_;
   RawArray* compile_time_constants_;
@@ skipping 13 matching lines @@
   friend class FullSnapshotWriter;
   friend class SnapshotReader;
   friend class VmIsolateSnapshotReader;
 
   DISALLOW_COPY_AND_ASSIGN(ObjectStore);
 };
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_STORE_H_