Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 1769123002: Disable UpdateProcessPriority() on startup by default. (Closed)

Created:
4 years, 9 months ago by gab
Modified:
4 years, 8 months ago
Reviewers:
ncarter (slow), sky, fdoray
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable UpdateProcessPriority() on startup by default. Ref https://cbug.com/560446#c22 for experiment results. BUG=579116, 560446, 601184 Note: PS1 copied from https://codereview.chromium.org/1763353002/ per incorrect base URL there. Committed: https://crrev.com/08d3d94b234905611bbba4cbcbba92477aa2987f Cr-Commit-Position: refs/heads/master@{#385608}

Patch Set 1 #

Patch Set 2 : merge up to r385455 #

Patch Set 3 : still do it on Android #

Patch Set 4 : bug # in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 1 chunk +14 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +6 lines, -9 lines 0 comments Download
M content/public/common/content_features.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (13 generated)
gab
TBR=nick@chromium.org (same CL as https://codereview.chromium.org/1763353002/) TBR=sky@chromium.org (for side-effects in chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc) Thanks, Gab
4 years, 9 months ago (2016-03-07 18:54:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769123002/1
4 years, 9 months ago (2016-03-07 18:55:09 UTC) #5
ncarter (slow)
lgtm
4 years, 9 months ago (2016-03-07 19:19:06 UTC) #6
fdoray
lgtm
4 years, 9 months ago (2016-03-07 19:26:45 UTC) #8
sky
LGTM
4 years, 9 months ago (2016-03-07 21:30:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34436)
4 years, 9 months ago (2016-03-07 22:06:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769123002/1
4 years, 9 months ago (2016-03-08 05:15:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34899)
4 years, 9 months ago (2016-03-08 07:47:01 UTC) #15
gab
@Nick: note can't do this on Android yet because of crbug.com/601184 (ref. email discussion in ...
4 years, 8 months ago (2016-04-06 20:48:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769123002/60001
4 years, 8 months ago (2016-04-06 20:49:45 UTC) #21
ncarter (slow)
On 2016/04/06 20:49:45, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 8 months ago (2016-04-06 23:02:46 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-07 01:06:03 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 01:07:14 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/08d3d94b234905611bbba4cbcbba92477aa2987f
Cr-Commit-Position: refs/heads/master@{#385608}

Powered by Google App Engine
This is Rietveld 408576698