Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1769123002: Disable UpdateProcessPriority() on startup by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bug # in comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 5ba612b18bf6b304bfbd7ac8088b7694a5514d5e..5ba1bc8e865bd5949b56f6b3d3068da843b266b6 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -2554,15 +2554,12 @@ void RenderProcessHostImpl::OnProcessLaunched() {
is_process_backgrounded_ =
child_process_launcher_->GetProcess().IsProcessBackgrounded();
-#if defined(OS_WIN)
- // Experiment with not setting the initial priority of a renderer, as this
- // might be a visible tab but since no widgets are currently present, it
- // will get backgrounded. See https://crbug.com/560446.
- if (base::FeatureList::IsEnabled(
- features::kUpdateRendererPriorityOnStartup)) {
- UpdateProcessPriority();
- }
-#else
+ // Disable updating process priority on startup for now as it incorrectly
+ // results in backgrounding foreground navigations until their first commit
+ // is made. A better long term solution would be to be aware of the tab's
+ // visibility at this point. https://crbug.com/560446.
+ // Except on Android for now because of https://crbug.com/601184 :-(.
+#if defined(OS_ANDROID)
UpdateProcessPriority();
#endif
}
« no previous file with comments | « chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc ('k') | content/public/common/content_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698