Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tests/RefCntTest.cpp

Issue 1769093002: add virtual ~Effect() (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: undo comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RefCntTest.cpp
diff --git a/tests/RefCntTest.cpp b/tests/RefCntTest.cpp
index f5345b6a54162354d782bf5466af19f4f1e83e1e..d3cda7f38d38b2a52c08a7ed97ce7808444d4618 100644
--- a/tests/RefCntTest.cpp
+++ b/tests/RefCntTest.cpp
@@ -99,6 +99,7 @@ public:
Effect() : fRefCnt(1) {
gNewCounter += 1;
}
+ virtual ~Effect() {}
int fRefCnt;
@@ -135,6 +136,8 @@ public:
};
struct EffectImpl : public Effect {
+ ~EffectImpl() override {}
+
static sk_sp<EffectImpl> Create() {
return sk_sp<EffectImpl>(new EffectImpl);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698