add virtual ~Effect()

tests/RefCntTest.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkRefCnt.h"
 #include "SkThreadUtils.h"
 #include "SkTypes.h"
@@ skipping 81 matching lines @@
     REPORTER_ASSERT(reporter, gUnrefCounter == unref);      \
     REPORTER_ASSERT(reporter, gNewCounter == make);         \
     REPORTER_ASSERT(reporter, gDeleteCounter == kill);
 
 
 class Effect {
 public:
     Effect() : fRefCnt(1) {
         gNewCounter += 1;
     }
+    virtual ~Effect() {}
 
     int fRefCnt;
 
     void ref() {
         gRefCounter += 1;
         fRefCnt += 1;
     }
     void unref() {
         gUnrefCounter += 1;
 
@@ skipping 16 matching lines @@
     sk_sp<Effect> fEffect;
 
     const sk_sp<Effect>& get() const { return fEffect; }
 
     void set(sk_sp<Effect> value) {
         fEffect = std::move(value);
     }
 };
 
 struct EffectImpl : public Effect {
+    ~EffectImpl() override {}
+
     static sk_sp<EffectImpl> Create() {
         return sk_sp<EffectImpl>(new EffectImpl);
     }
     int fValue;
 };
 static sk_sp<Effect> make_effect() {
     auto foo = EffectImpl::Create();
     foo->fValue = 42;
     return std::move(foo);
 }
@@ skipping 153 matching lines @@
     sp.reset(rc);
     // We have transfered our ownership over to sp
     REPORTER_ASSERT(r, rc->unique());
 
     rc->ref();  // now "rc" is also an owner
     REPORTER_ASSERT(r, !rc->unique());
 
     sp.reset(rc);   // this should transfer our ownership over to sp
     REPORTER_ASSERT(r, rc->unique());
 }