Issue 176903004: Have Document::timeline() / Document::transitionTimeline() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176903004: Have Document::timeline() / Document::transitionTimeline() return a reference (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
adamk

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, adamk+blink_chromium.org, darktears, Steve Block, dino_apple.com, Inactive, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Document::timeline() / Document::transitionTimeline() return a reference Have Document::timeline() / Document::transitionTimeline() return a reference instead of a pointer as they can never return null. This makes the calling code look safer and gets rid of a few unnecessary null checks. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167940

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -40 lines)			Patch
M	Source/core/animation/AnimationTest.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/animation/DocumentAnimation.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/DocumentAnimations.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/animation/DocumentTimelineTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/ElementAnimation.cpp	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/dom/Document.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/176903004/1

6 years, 10 months ago (2014-02-26 19:15:10 UTC) #3

Message was sent while issue was closed.

Change committed as 167940

Expand Messages | Collapse Messages